Fixes #124 #125
Merged
Fixes #124 #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We'll need to wait for #123 to be accepted before this is merge-able. I branched from that branch and isn't on |
|
@nicklucius - now that #123 is merged to |
nicklucius
approved these changes
Mar 8, 2017
nicklucius
added a commit
that referenced
this pull request
Apr 12, 2017
* Added unit tests for issue #118 * Add unit test for #120 * Bug fix - fixes #120 * Update version number * Fixes #124 (#125) * Added testing for issue #121 -- will fail * Changed to camel case to accomodate future variable renaming * Added handling of ISO 8601 timestamps without fractional seconds. See issue #121 * Increased minimum version of R because of `anyNA` function. * Unformatted dates kept as chr; added warning; added tests * Added tests for #124 -- will fail * Handles downloadURL from ls.socrata. Fixes #124 * Closes #129 * Iteration version * startsWith() requires R >= 3.3.0 * Resolves #133. Also documents per #132 * Updated to reflect consequence of #133 * resolved merge conflict from rebasing * fixing test - dataset is live so rows can increase, and fixed data types. * add unit test for issue #118 - will fail * fixes #118 * Add .gitattributes, ignores it during R build. Closes #135 * Fixes #134 * Clarified language on installing from GitHub * Removed penultimate release from build testing. Closes #136 * Updated formatting for sections * Update NEWS.md for 1.7.2 release. * Included remaining changes to NEWS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read.socrataends withrows.csvorrows.json. If so, will rearrange the URL to be a valid API call.rows.jsonandrows.csv. Note: this does not supportrows.rdforrows.xml, even though that is returned fromls.socrata()