Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #121 #123

Merged
merged 5 commits into from
Mar 7, 2017
Merged

Fixes #121 #123

merged 5 commits into from
Mar 7, 2017

Conversation

tomschenkjr
Copy link
Contributor

  • Add ability to handle date/time formats as YYYY-MM-DDTHH:MM:SS -- fixes NA's from date fields when reading JSON's #121
  • If the date/time format is not properly converted, RSocrata returns the data as chr strings instead of NA. This will let the user manually convert if necessary and will reduce the severity of errors like these in the future (there are several date formats we are not handling right now)
  • A warning has been added to alert users they will not have a POSIX-formatted column.

@coveralls
Copy link

coveralls commented Feb 24, 2017

Coverage Status

Coverage increased (+0.2%) to 96.407% when pulling b0ce826 on issue121 into 7714a0e on master.

Author: Hugh Devlin, Ph. D., Tom Schenk, Jr., and John Malc
Maintainer: "Tom Schenk Jr." <developers@cityofchicago.org>
Depends:
R (>= 3.0.0)
R (>= 3.1.0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomschenkjr I'm curious why this change incremented the dependency from R 3.0 to R 3.1

@tomschenkjr
Copy link
Contributor Author

tomschenkjr commented Mar 3, 2017 via email

@tomschenkjr tomschenkjr mentioned this pull request Mar 4, 2017
@geneorama geneorama merged commit dfa7001 into master Mar 7, 2017
@tomschenkjr tomschenkjr modified the milestone: 1.7.2 Mar 7, 2017
@PriyaDoIT PriyaDoIT deleted the issue121 branch April 12, 2017 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NA's from date fields when reading JSON's
3 participants