-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #121 #123
Merged
Fixes #121 #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geneorama
reviewed
Mar 3, 2017
Author: Hugh Devlin, Ph. D., Tom Schenk, Jr., and John Malc | ||
Maintainer: "Tom Schenk Jr." <developers@cityofchicago.org> | ||
Depends: | ||
R (>= 3.0.0) | ||
R (>= 3.1.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tomschenkjr I'm curious why this change incremented the dependency from R 3.0 to R 3.1
The `anyNA()` function became available in 3.1 https://journal.r-project.org/archive/2014-1/r-changes.pdf
While the function itself is simple and we can replicate it (http://www.renjin.org/blog/2015-12-30-a-critical-look-at-the-anyna-function-in-r.html), 3.1 seems old enough where it is unlikely to impact users.
_
Tom Schenk Jr.
Chief Data Officer
Department of Innovation and Technology
City of Chicago
(312) 744-2770
tom.schenk@cityofchicago.org | @ChicagoCDO
data.cityofchicago.org | opengrid.io | digital.cityofchicago.org | chicago.github.io | dev.cityofchicago.org
On Fri, Mar 3, 2017 at 10:41 AM -0600, "Gene Leynes" <notifications@github.com<mailto:notifications@github.com>> wrote:
@geneorama commented on this pull request.
________________________________
In DESCRIPTION<#123 (comment)>:
Author: Hugh Devlin, Ph. D., Tom Schenk, Jr., and John Malc
Maintainer: "Tom Schenk Jr." <developers@cityofchicago.org>
Depends:
- R (>= 3.0.0)
+ R (>= 3.1.0)
@tomschenkjr<https://github.com/tomschenkjr> I'm curious why this change incremented the dependency from R 3.0 to R 3.1
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#123 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABkC0Vno1Gkl1uSA3OnpyVWp6ho34Or8ks5riELAgaJpZM4MK0c3>.
…________________________________
This e-mail, and any attachments thereto, is intended only for use by the addressee(s) named herein and may contain legally privileged and/or confidential information. If you are not the intended recipient of this e-mail (or the person responsible for delivering this document to the intended recipient), you are hereby notified that any dissemination, distribution, printing or copying of this e-mail, and any attachment thereto, is strictly prohibited. If you have received this e-mail in error, please respond to the individual sending the message, and permanently delete the original and any copy of any e-mail and printout thereof.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YYYY-MM-DDTHH:MM:SS
-- fixes NA's from date fields when reading JSON's #121chr
strings instead ofNA
. This will let the user manually convert if necessary and will reduce the severity of errors like these in the future (there are several date formats we are not handling right now)