Split functions and other smaller improvements for 1.6.3 #53

dmpe · 2015-07-16T16:13:59Z

Merge after code review. This is a tentative changelog:

Bump to 1.6.x (future release), which as described in [META: Ideas for near future] #50 should have better error handling and splitted functions (ErrorHandling.R).
4x4 is now improved as one test in the test-fourByFour - the isFourByFour("4334-!gaj") - would fail (on my PC) with RSocrata CRAN version.
RSocrata.R is renamed into returnData.R, the same is with the getResponse -> checkResponse (this function is now quite unnecessary though)
Added 3rd. regex for the http://dev.socrata.com/docs/datatypes/floating_timestamp.html
Added some examples & tests and some general formatting according to style guide
Added vignette (with geo example & move all examples out of the readme file)
- Tests on Travis take long, but it is ok
- other small changes to .md files

Before merging/releasing on CRAN, this can/needs to be done:

delete note.md.
(Error in rbind(deparse. level, ...) #19) -> to consider ?
Finish one unit test in testDatetime.R -> Add unit test for an NA datetime in source #27
Update News file
Version 1.6.3. or 1.6.2 ?
Reconsider @exporting fieldName and isFourByFour functions. Shouldn't they be invisible to the user, i.e. @noRd

Current File Structure in `R` folder:

returnData.R has 4 functions:

read.socrata
checkResponse
getContentAsDataFrame
getSodaTypes

utils.R has 2 functions:

fieldName
posixify
isFourByFour

validateURL.R has 1 function:

validateUrl

listDatasets.R has 1 function:

ls.socrata

errorHandling.R has 1 function:

errorHandling

Dev

bump to 1.6.3 Add new Floatin Timestamp format for posixify + add test

dmpe · 2015-07-18T18:19:23Z

note.md

@@ -0,0 +1,6 @@
+Hi @tomschenkjr, 
+Can I just ask something ? We have a function called posixify which "Converts Socrata calendar_date string to POSIX". Can you give me an example of a such string that is then converted to POSIX ?
+


already found (see examples)

fix travis again

dmpe · 2015-07-19T17:08:31Z

https://stackoverflow.com/questions/10699511/difference-between-as-posixct-as-posixlt-and-strptime-for-converting-character-v for #8

and rename getResponse to checkResponse update test

[skip ci]

dmpe · 2015-07-19T17:59:14Z

tests/testthat/test-dateTime.R

+  expect_equal(47, dt$sec, label="seconds")
+})
+
+test_that("NA datetime in source", {


do somehting with the speed and dplyr

dmpe · 2015-07-22T20:15:22Z

Hello @tomschenkjr & @geneorama,

Above you can find what changes / (smaller) improvements I have made to the package. Can you please take a look at that, over here https://github.com/Chicago/RSocrata/pull/53/files. I went a bit over the sprint7 branch, but did rather very smaller changes to the overall code.

Thank you.

tomschenkjr · 2015-07-23T01:04:41Z

Fantastic. I'll take a look at it. Might be a couple of days before I get a chance.

Conflicts: DESCRIPTION

…be moved to required) should fix travis now fix again second time the same. give up give up on travis. wont work ?

again

update functions, move 4x4 to utils.R update docu + .md files

tomschenkjr · 2015-07-25T23:15:16Z

Accepting pull request. Can you separate-out the additional commits from outstanding pull requests, though? It's getting a bit treacherous trying to track the status of the CI status on this one.

Split functions and other smaller improvements

Merge pull request Chicago#51 from Chicago/dev Pull request for v1.6.1 Remove NEWS.md from build to avoid NOTE Build number bump and date change R 3.2.1 wants all URLs in canonical form--has been changed Fix type-o in Coveralls badge Merge remote-tracking branch 'upstream/dev' into dev split & improve 4x4 logic (tests pass) bump to 1.6.3 Add new Floatin Timestamp format for posixify + add test split validate + test validate url split test fix travis don't run, not do not run fix travis again add errorHandling function and rename getResponse to checkResponse update test else if [skip ci] add not finished test for Chicago#27, Chicago#24 [skip ci] go over sprint7 branch [skip ci] text/plain [skip ci] fix paste -> paste0 because of sep="" which I deleted delete note.md + update date [skip ci] geo readme Merge remote-tracking branch 'upstream/dev' into dev Merge remote-tracking branch 'origin/dev' into dev Conflicts: DESCRIPTION add geojson example & vignette (dependencies are suggested, later to be moved to required) should fix travis now fix again second time the same. give up give up on travis. wont work ? fix last time again tests and comments (geo too) update functions, move 4x4 to utils.R update docu + .md files add geojson support. not finished Merge pull request Chicago#53 from dmpe/dev Split functions and other smaller improvements fix leaflet example, not SP object but the list and add a new contributor fix test [skip ci] Merge pull request Chicago#56 from dmpe/dev-geojson-big bind -> rbind.fill; getMetadata; GeoJSON method Fixed version number scheme Using building numbers, x.y.z-b. The "z" should only be incremented on bug releases being planned. Human-readable URLs are not being deprecated Fixes build url under certain domain cases Re-added human-readable URL Added unit tests for broken-out URLs Removed unnecessary library listings Cleaned-up documentation Increment build info Updated help files Removed vignettes, updated documentation for style Example formatting issues, cleaned-up comments Turned on tests Examples on read.socrata taking too long, stopped their run Merge pull request #4 from Chicago/dev Dev

dmpe and others added 6 commits July 11, 2015 10:10

Merge pull request #1 from Chicago/dev

df10c4d

Dev

format

b4c63a5

tests are passing, format again

fc3ea63

maybe bad ?

d5ccb39

Merge remote-tracking branch 'upstream/dev' into dev

d018006

split & improve 4x4 logic (tests pass)

d799913

bump to 1.6.3 Add new Floatin Timestamp format for posixify + add test

dmpe reviewed Jul 18, 2015
View reviewed changes

dmpe added 4 commits July 18, 2015 20:40

split validate + test

b40c752

validate url split test

929ab8d

fix travis

eb5f340

don't run, not do not run

6e4da7a

fix travis again

dmpe added 2 commits July 19, 2015 19:19

add errorHandling function

2918647

and rename getResponse to checkResponse update test

else if [skip ci]

059b790

dmpe mentioned this pull request Jul 19, 2015

[META: Ideas for near future] #50

Closed

4 tasks

add not finished test for Chicago#27, Chicago#24

1ee4421

[skip ci]

dmpe reviewed Jul 19, 2015
View reviewed changes

dmpe added 2 commits July 19, 2015 20:34

go over sprint7 branch [skip ci]

f189c52

text/plain [skip ci]

a6eb5b5

dmpe changed the title ~~[Ignore please/do not merge]~~ Split functions and other smaller improvements Jul 20, 2015

dmpe changed the title ~~Split functions and other smaller improvements~~ Split functions and other smaller improvements for 1.6.3 Jul 20, 2015

dmpe added 2 commits July 22, 2015 21:47

fix paste -> paste0 because of sep="" which I deleted

f680475

delete note.md + update date [skip ci]

c8d7ac0

tomschenkjr self-assigned this Jul 23, 2015

dmpe added 4 commits July 23, 2015 21:48

geo readme

8131e4a

Merge remote-tracking branch 'upstream/dev' into dev

34b6a64

Merge remote-tracking branch 'origin/dev' into dev

9e4363a

Conflicts: DESCRIPTION

add geojson example & vignette (dependencies are suggested, later to …

61e7f19

…be moved to required) should fix travis now fix again second time the same. give up give up on travis. wont work ?

dmpe force-pushed the dev branch from c18b996 to 61e7f19 Compare July 23, 2015 21:07

fix last time

c056052

again

dmpe force-pushed the dev branch from c783f6d to c056052 Compare July 23, 2015 21:27

tests and comments (geo too)

9f13178

update functions, move 4x4 to utils.R update docu + .md files

tomschenkjr pushed a commit that referenced this pull request Jul 25, 2015

Merge pull request #53 from dmpe/dev

4364566

Split functions and other smaller improvements

tomschenkjr merged commit 4364566 into Chicago:dev Jul 25, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Split functions and other smaller improvements for 1.6.3 #53

Split functions and other smaller improvements for 1.6.3 #53

dmpe commented Jul 16, 2015

dmpe Jul 18, 2015

dmpe commented Jul 19, 2015

dmpe Jul 19, 2015

dmpe commented Jul 22, 2015

tomschenkjr commented Jul 23, 2015

tomschenkjr commented Jul 25, 2015

		@@ -0,0 +1,6 @@
		Hi @tomschenkjr,
		Can I just ask something ? We have a function called posixify which "Converts Socrata calendar_date string to POSIX". Can you give me an example of a such string that is then converted to POSIX ?

Split functions and other smaller improvements for 1.6.3 #53

Split functions and other smaller improvements for 1.6.3 #53

Conversation

dmpe commented Jul 16, 2015

Merge after code review. This is a tentative changelog:

Before merging/releasing on CRAN, this can/needs to be done:

Current File Structure in R folder:

dmpe Jul 18, 2015

Choose a reason for hiding this comment

dmpe commented Jul 19, 2015

dmpe Jul 19, 2015

Choose a reason for hiding this comment

dmpe commented Jul 22, 2015

tomschenkjr commented Jul 23, 2015

tomschenkjr commented Jul 25, 2015

Current File Structure in `R` folder: