Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[META: Ideas for near future] #50

Closed
4 tasks done
dmpe opened this issue Jul 10, 2015 · 2 comments
Closed
4 tasks done

[META: Ideas for near future] #50

dmpe opened this issue Jul 10, 2015 · 2 comments

Comments

@dmpe
Copy link
Contributor

dmpe commented Jul 10, 2015

This is meta issue (for myself; label would be nice however)

See also
https://github.com/Chicago/RSocrata/wiki/Roadmap#planned-releases

@tomschenkjr tomschenkjr changed the title [META: Idias for near future] [META: Ideas for near future] Jul 10, 2015
@dmpe
Copy link
Contributor Author

dmpe commented Jul 11, 2015

@geneorama
How does it look with the sprint7 branch ? So many good changes but somehow abandoned, fixing bugs such as #19.

Before one tackles e.g. #43 I think it would be good to incorporate many of them, e.g. splitting RSocrata.R in at least 3 R files or making it more according to style guide (google + hadley etc.)

@tomschenkjr
Copy link
Contributor

@dmpe-

  • Yeah. We're going to modify it a bit since we have some ways we approach things (e.g., package::function).
  • Absolutely, we need some better error handling for HTTP issues instead of relying on httr's returns. Will help with the unit testing issues Issue Add specific error message for non-SoDA resource #16 is similar and is need
  • On closing issues, they're often closed when we finally push to master since "closing" is included in the commit message.
  • @geneorama changes--as a whole--were pretty big and are aiming to be incorporated in the v2 of the package. I see some new functions or at least the structure of functions needing to change because of the new API functionality (e.g., Add support for geojson downloads #43).

We may want to make some of these changes in minor and bug releases. For instance, 1.6.2 to split R files and better error handling. Then #43 can be slated for v1.7 or 2.0 depending if we get this all done at once. However, I think we need to change the function syntax a bit (see sprint7 branch) to accomidate some of Socrata's new API functionality.

I've updated the roadmap to reflect some of these desires in version 2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants