Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Containerized react resolving #18 #100

Merged
merged 48 commits into from
Apr 7, 2023
Merged

Containerized react resolving #18 #100

merged 48 commits into from
Apr 7, 2023

Conversation

briswells
Copy link
Contributor

No description provided.

@briswells
Copy link
Contributor Author

commit includes update to github actions for backend. Currently failing because backend is now in a different directory.

@briswells briswells requested a review from Jooms April 6, 2023 03:36
@briswells briswells linked an issue Apr 6, 2023 that may be closed by this pull request
Containerize MVP #18
Closed
2 tasks
@Jooms
Copy link
Contributor

Jooms commented Apr 6, 2023 •
edited
Loading

Looks good, Approval pending fix of the backend build and lint checks.

Or, don't move the backend and I'll handle it separately.

briswells and others added 9 commits April 6, 2023 10:22
@briswells
removed package-lock.json from ignores
a8d28ea
@briswells
Updated linter action - TEST
0b51ce0
@briswells
Updated linter action - TEST
0f26c5b
@briswells
Updated branch name
1c0212c
@briswells
Updated branch name
59a10f6
@briswells
test commit for linter
ce42da5
@briswells
test commit for linter
9cf4c06
@briswells
linter update to main
100ee5d
@rohitkarhadkar @sourabhk25
Issue #21: Add infrastructure for automated testing. (#75)
1197761 
* Issue #21: Added infrastructure for automated testing

* Issue #21: Fixed package-lock.json

* Removed 'node', '--passWithNoTests' and extra code for smoke test

* Resolved conflicts in package.json and package-lock.json

* package.json modified to solve lint errors.

* package-lock.json fixed

---------

Co-authored-by: sourabhk25 <sourabhkulkarni258@gmail.com>
Jooms
Jooms previously approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@Jooms Jooms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with comments.

backend/app.js Outdated Show resolved Hide resolved
Jooms
Jooms previously approved these changes Apr 6, 2023
View reviewed changes
@briswells briswells requested a review from Jooms April 6, 2023 22:59
reembot
reembot approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@reembot reembot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@briswells briswells merged commit b70e688 into main Apr 7, 2023
@briswells briswells deleted the containerize-React branch April 7, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jooms Jooms Jooms approved these changes

@reembot reembot reembot approved these changes

@prestonmasseyblake prestonmasseyblake Awaiting requested review from prestonmasseyblake

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Containerize MVP
4 participants
@briswells @Jooms @reembot @rohitkarhadkar