Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/donar page static #105

Merged
merged 5 commits into from
Apr 7, 2023
Merged

Conversation

kushalramakanth
Copy link
Contributor

Developed Donar Page and

  • added donar creation form
  • Created table of donars

Copy link
Contributor

@hardikpatil hardikpatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Sorting works as well on datatable.

Screenshot 2023-04-06 at 14 05 26
Screenshot 2023-04-06 at 14 05 50
Screenshot 2023-04-06 at 14 05 57
Screenshot 2023-04-06 at 14 06 15

@DevangRaval1
Copy link
Contributor

Everything works on my end too.

DevangRaval1
DevangRaval1 previously approved these changes Apr 7, 2023
Copy link
Contributor

@DevangRaval1 DevangRaval1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DevangRaval1 DevangRaval1 dismissed their stale review April 7, 2023 02:59

There are no validations added to the email

@DevangRaval1 DevangRaval1 self-requested a review April 7, 2023 03:04
Copy link
Contributor

@DevangRaval1 DevangRaval1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the discussion with @kushalramakanth validations and redirection will be in a different PR

@kushalramakanth kushalramakanth merged commit 7452ce1 into frontend Apr 7, 2023
@kushalramakanth kushalramakanth deleted the feature/donar-page-static branch April 7, 2023 03:07
@hardikpatil hardikpatil added the UI Concerns UI presentation label Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI Concerns UI presentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants