Added formik to register page. Fixed issue #123 #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SANDESHSOBARAD
requested review from
hardikpatil,
sathyanarayanan-v and
priyankavrao97
priyankavrao97
approved these changes
Apr 11, 2023
|
Some problem with validation |
|
@SANDESHSOBARAD Can we have a "view password" icon inside the password field, also the "confirm password" field which re-confirms the password set? |
|
Yes, I will work on that. |
|
Looks good to me. Can you add the same
|
|
I think it doesn't need to be there, cause if the password field and confirm password field are not matching it won't let you sign up. Basically you can see what you typed in the password field and type the same in confirm password field to match. |
abhilashSreenivasa
approved these changes
Apr 12, 2023
hardikpatil
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.