Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authenticate routes #239

Merged
merged 4 commits into from
May 14, 2023
Merged

Authenticate routes #239

merged 4 commits into from
May 14, 2023

Conversation

parthpandey1
Copy link
Contributor

Added authentication to existing endpoints on sale.js. Resolves #235

jayrevolinskyjr
jayrevolinskyjr approved these changes May 13, 2023
View reviewed changes
Copy link
Contributor

@jayrevolinskyjr jayrevolinskyjr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Authentication works great, return 401 with bad token.
add_donorauthworkingneg
Works with an appropriate token! This is outside of the scope of the current issue and is likely a non-issue, but calling the POST routes naively caused my machine to hang.
401works

hardikpatil
hardikpatil approved these changes May 13, 2023
View reviewed changes
Copy link
Contributor

@hardikpatil hardikpatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Threw some err but auth does work though.

@hardikpatil hardikpatil merged commit 7a988fd into main May 14, 2023
@hardikpatil hardikpatil deleted the authenticate_routes branch May 14, 2023 21:19
@hardikpatil hardikpatil added backend concerns backend/API presentation api-integration Work with the backend team for API integration. labels May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardikpatil hardikpatil hardikpatil approved these changes

@jayrevolinskyjr jayrevolinskyjr jayrevolinskyjr approved these changes

@briswells briswells Awaiting requested review from briswells

@AbhinavReddy-Dev AbhinavReddy-Dev Awaiting requested review from AbhinavReddy-Dev

Assignees
No one assigned
Labels
api-integration Work with the backend team for API integration. backend concerns backend/API presentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add authentication to existing routes.
3 participants
@parthpandey1 @hardikpatil @jayrevolinskyjr