-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added isolated directory for React #22 #36
Conversation
@@ -0,0 +1,3 @@ | |||
# PantryNode | |||
|
|||
This is the typescript react frontend of Pantry Node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly add the steps to build and run?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great idea adding commands to the read me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks alright to me.
"scripts": { | ||
"start": "react-scripts start", | ||
"build": "react-scripts build", | ||
"test": "react-scripts test", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please let the testing dependencies remain untouched until we start writing tests for the components.
@@ -0,0 +1,25 @@ | |||
{ | |||
"short_name": "React App", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update this.
"name": "Create React App Sample", | ||
"icons": [ | ||
{ | ||
"src": "favicon.ico", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a generalized icon replace this.
@@ -0,0 +1,38 @@ | |||
.App { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to remove this file once we configure Tailwind CSS.
import logo from './logo.svg'; | ||
import './App.css'; | ||
|
||
function App() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to setup Routing and State Management.
I'm not sure if we can close the #22 issue yet, we haven't completely finished the migration. I think we need to decide on the point where we can close the issue. Until then we can create sub-issues related to that main issue, like creating a folder for react, setting up Tailwind CSS, setting up routing, setting up state management etc. Please add your thoughts! |
* Switch from TravisCI to Github Actions * Try ubuntu latest * Install and start * Patch UseUnifiedTopology bug * npm test * Try start and build flag * Add 'run' * re-add install * try bad files * remove junk * clean up other files touched * Add build action on push to main * Added Build Node Status Badge * Replaced TravisCI with GithubActions StatusBadge --------- Co-authored-by: James Krepelka <jameskrepelka@gmail.com> Co-authored-by: Jay Revolinsky <98365370+jayrevolinskyjr@users.noreply.github.com> Co-authored-by: Yashvi <ysiddhapura@mail.csuchico.edu> Co-authored-by: Anoushka Sharma <35841938+Anoushka444@users.noreply.github.com>
No description provided.