Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added isolated directory for React #22 #36

Merged
merged 2 commits into from
Mar 6, 2023
Merged

Conversation

prestonmasseyblake
Copy link
Contributor

No description provided.

@decoles decoles self-requested a review March 2, 2023 20:12
@@ -0,0 +1,3 @@
# PantryNode

This is the typescript react frontend of Pantry Node
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly add the steps to build and run?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great idea adding commands to the read me

@AbhinavReddy-Dev AbhinavReddy-Dev changed the title closes #22 Added isolated directory for React, closes #22 Mar 4, 2023
Copy link
Contributor

@AbhinavReddy-Dev AbhinavReddy-Dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright to me.

"scripts": {
"start": "react-scripts start",
"build": "react-scripts build",
"test": "react-scripts test",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let the testing dependencies remain untouched until we start writing tests for the components.

@@ -0,0 +1,25 @@
{
"short_name": "React App",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update this.

"name": "Create React App Sample",
"icons": [
{
"src": "favicon.ico",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a generalized icon replace this.

@@ -0,0 +1,38 @@
.App {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove this file once we configure Tailwind CSS.

import logo from './logo.svg';
import './App.css';

function App() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to setup Routing and State Management.

@AbhinavReddy-Dev
Copy link
Contributor

I'm not sure if we can close the #22 issue yet, we haven't completely finished the migration. I think we need to decide on the point where we can close the issue. Until then we can create sub-issues related to that main issue, like creating a folder for react, setting up Tailwind CSS, setting up routing, setting up state management etc. Please add your thoughts!

* Switch from TravisCI to Github Actions

* Try ubuntu latest

* Install and start

* Patch UseUnifiedTopology bug

* npm test

* Try start and build flag

* Add 'run'

* re-add install

* try bad files

* remove junk

* clean up other files touched

* Add build action on push to main

* Added Build Node Status Badge

* Replaced TravisCI with GithubActions StatusBadge

---------

Co-authored-by: James Krepelka <jameskrepelka@gmail.com>
Co-authored-by: Jay Revolinsky <98365370+jayrevolinskyjr@users.noreply.github.com>
Co-authored-by: Yashvi <ysiddhapura@mail.csuchico.edu>
Co-authored-by: Anoushka Sharma <35841938+Anoushka444@users.noreply.github.com>
@AbhinavReddy-Dev AbhinavReddy-Dev changed the title Added isolated directory for React, closes #22 Added isolated directory for React #22 Mar 6, 2023
@prestonmasseyblake prestonmasseyblake merged commit 35db046 into main Mar 6, 2023
@prestonmasseyblake prestonmasseyblake deleted the frontend branch March 6, 2023 21:06
briswells pushed a commit that referenced this pull request Mar 23, 2023
Closing this issue then going to open more specific issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants