Resolved linter semicolon issues. #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…changes to resolve semicolon issues. Fixes #48
parthpandey1
requested review from
Jooms,
reembot,
Anoushka444,
jayrevolinskyjr and
ysiddhapura
Jooms
previously approved these changes
Mar 9, 2023
.eslintrc.cjs
Outdated
| @@ -5,7 +5,7 @@ module.exports = { | |||
| root: true, | |||
| rules: { | |||
| "@typescript-eslint/no-var-requires": "warn", | |||
| "@typescript-eslint/no-extra-semi": "warn", | |||
| "@typescript-eslint/no-extra-semi": "error", | |||
There was a problem hiding this comment.
Just remove the entire line. warn was an override. Setting it to error is letting it go back to the default.
jayrevolinskyjr
requested changes
Mar 9, 2023
There was a problem hiding this comment.
I agree with @Jooms , removing the no-extra-semi line will resolve this
jayrevolinskyjr
changed the title
|
Looking good! |
decoles
previously approved these changes
Mar 12, 2023
parthpandey1
dismissed stale reviews from decoles and jayrevolinskyjr
via
1cdabd5
hardikpatil
approved these changes
Mar 29, 2023
jayrevolinskyjr
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed rule in .eslintrc.cjs for extra semicolons to show error instead of warning. Resolved extra semicolon issues.