Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newly created alarms do not wait for accurate time to notify user #2

Closed
cboatsman opened this issue Sep 20, 2017 · 1 comment
Closed
Assignees
Labels

Comments

@cboatsman
Copy link
Collaborator

When creating a new alarm, the notification to a users device happens almost immediately upon creation of the alarm. Instead, it should be waiting to send notification upon the actual alarm event taking place at the specified time. I am unsure as to whether or not this issue is related to the alarm not properly being created, or if it is an issue with the AlarmReceiver or AlarmService.

@cboatsman cboatsman added the bug label Sep 20, 2017
cboatsman added a commit that referenced this issue Sep 20, 2017
…notify the user at an appropriate time which is selected
@cboatsman cboatsman self-assigned this Sep 20, 2017
cboatsman added a commit that referenced this issue Sep 21, 2017
- New alarm now waits for the appropriate time chosen before notifying the user
@cboatsman
Copy link
Collaborator Author

Still need to add much more to the alarm system as a whole, but as of right now I have tested and verified that the alarm now waits for the appropriately chosen time before user notification is sent.

One further issue with this that I have noticed is that the phone/device must not be sleeping (needs to be on, app needs to be running) otherwise the notification does not seem to come. However, this will be addressed in a different issue.

Closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant