Allow running without root #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A typo was causing an errors.
It can be called as steam-buddy@username like so: systemctl start steam-buddy@gamer
alkazar
requested changes
Nov 20, 2019
steam-buddy
Outdated
| DATA_DIR = '/var/lib/steam-buddy' | ||
| else: | ||
| HOST_PORT = 8080 | ||
| DATA_DIR = os.path.join(os.path.expanduser('~'), '.local/share/steam-buddy') |
There was a problem hiding this comment.
we need to honour the XDG_DATA_HOME environment variable as well. ~/.local/share is only the default location. See https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html
There was a problem hiding this comment.
Good point, it now uses the XDG_DATA_HOME when possible, otherwise it falls back to ~/.local/share.
| @@ -0,0 +1,16 @@ | |||
| [Unit] | |||
There was a problem hiding this comment.
do we still need the other service file?
There was a problem hiding this comment.
Good question. Possibly not, but if you still want to be able to run as root you may want to keep it. I haven't really tested running the new service file as root and running it as steam-buddy@root is a bit weird. It probably does work, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows steam-buddy to be started as a regular user. When not running as root, you may notice the following differences:
~/.local/share/steam-buddy. This one will require a small change to steam-shortcuts.To start steam-buddy as a regular user, you can either just run the application directly or use the newly included
steam-buddy@service file. Once installed in/etc/systemd/system/this file can be used withsystemctl start steam-buddy@username. Enabling it as the gamer user would be done withsudo systemctl enable steam-buddy@gamer.This pull request fixes issue #9