Fix tests, add svg_uri field, and fix CollectorNumber type #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated card image uri * Changed compressed_size field to size
* added svg_uri field to CardSymbol interface
* created CollectorNumber type for easy consistent typing * replaced all collectorNumber parameters to use this new type
furgin
changed the title
|
Thanks again! Will make a new release in just a bit 🤍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56 - Test Failures by updating the host uris and bulk data types
Fixes #55 - Adds the new field to the CardSymbol type
Fixes #58 - Consistently applies the new CollectorNumber type to all bySet methods