Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary line <hr> in "other videos" #4280

Closed
artemanufrij opened this issue Jul 27, 2021 · 4 comments
Closed

Unnecessary line <hr> in "other videos" #4280

artemanufrij opened this issue Jul 27, 2021 · 4 comments
Labels
good first issue Type: Feature Request ✨ UI non-trivial UI changes, that might need discussion

Comments

@artemanufrij
Copy link

The line is drawn only after the first video. In my opinion, the line should be removed. It looks confusing.

image
@Chocobozzz
Copy link
Owner

Chocobozzz commented Aug 5, 2021 •
edited
Loading

The line is here to highlight the fact it will be the next played video. But I agree it's not very clear.

I think we should use a label near the video title to explain it will be the next video to be played (and hide it if "autoplay next" is disabled)

@Chocobozzz Chocobozzz added Type: Feature Request ✨ UI non-trivial UI changes, that might need discussion labels Aug 5, 2021
@ghost
Copy link

ghost commented Sep 5, 2021

Hello guys. I decided to start offering my help for projects on GitHub. If you agree, I can assign myself and change that behavior if no-one is already on it.

@artemanufrij
Copy link
Author

@arnaud-ober , it would be great!

Poslovitch added a commit to Poslovitch/PeerTube that referenced this issue Oct 25, 2021
@Poslovitch
Added label on the next autoplayed video
a708f37 
Implements Chocobozzz#4280

Also hid the hr line if autoplay is disabled
@Poslovitch Poslovitch mentioned this issue Oct 25, 2021
Merged
1 task
Chocobozzz pushed a commit that referenced this issue Oct 26, 2021
@Poslovitch
Added label on the next autoplayed video and hide the hr line if unne…
db581cf 
…cessary (#4497)

* Added label on the next autoplayed video

Implements #4280

Also hid the hr line if autoplay is disabled

* Applied code suggestion

* Applied code suggestion

* Applied the last remaining code suggestion
@Poslovitch
Copy link
Contributor

hey @Chocobozzz, don't forget to close this one now that it's done ! 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Type: Feature Request ✨ UI non-trivial UI changes, that might need discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Chocobozzz @rigelk @artemanufrij @Poslovitch