-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/multiple classnames #1074
fix/multiple classnames #1074
Conversation
Thanks for this! Can you merge the latest version of |
Done ;-) |
I have a feeling that when @mtriff will get back to this, @gaetan-hexadog will need to merge latest |
@mtriff let me know when you'll be able to merge this PR so I can merge the latest version of |
Hey, does anyone know when this PR will be merged? |
+1 |
2 similar comments
+1 |
+1 |
Please come back, we need the multiple class override, thx |
We need this |
@gaetan-hexadog Whats with this? |
No news from the repo'd owner. I won't work on it for the third time if I don't have the insurance it will be merged quickly. |
There should be a protocol for when the owner stops responding for more than a year... |
Thanks! Implemented as part of #1166 |
Description
In some cases, we want to be able to pass multiple class names like so 'list first second'. However, this is making an error because classList.add doesn't support space.
This PR attempts to implement allowing multi-class configs for all elements across the board by allowing to pass an array of strings for classNames.
It takes into account feedbacks from PR#907 submitted by @mikebronner
Fix #832 #889
Types of changes
Checklist