Fix mixed optgroups #1110
Closed
Fix mixed optgroups #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes Choices-js#615. This pushes the conversion of OPTION/OPTGROUP elements to Choice objects into the WrappedSelect class and unifies the code paths a little between groups-present and groups-not-present. Some work towards possibly fixing Choices-js#615
4 tasks
nikitos-mv
approved these changes
Mar 29, 2024
|
Wow I forgot about this PR.... anyone we could ping to move this forward? |
|
Thanks! Implemented as part of #1166 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #615 basically.
It includes a working cypress test. I did not add unit tests, but I'd be happy to do so if you are planning to merge this.
Screenshots (if appropriate)
Types of changes
I'd call it a bug (see #615 ) but some might call it a new feature? Also minor refactorings.
Checklist
I think it's worth a mention in the changelog though.