Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arrow key navigation in tables seem to take precedence over keymappings for up/down instrument and command. #71

Closed
micheldebree opened this issue Oct 5, 2020 · 0 comments · Fixed by #72
Closed

Arrow key navigation in tables seem to take precedence over keymappings for up/down instrument and command. #71

micheldebree opened this issue Oct 5, 2020 · 0 comments · Fixed by #72
Assignees
@micheldebree
Labels
bug Something isn't working macos Applies only to the macos version

Comments

@micheldebree
Copy link
Collaborator

micheldebree commented Oct 5, 2020 •
edited
Loading

Found by Adam Davidovics

In any of the tables, the up/down keys move through the table, but the Cmd+up/down and Shift+Cmd+up/down also move through the table and do not update the current instrument or command, like it should.

This also goes for the bookmarks list

The global order list does both when pressing Cmd+up/down: it moves through the list aswell as select another instrument.
@micheldebree micheldebree self-assigned this Oct 5, 2020
@micheldebree micheldebree added the macos Applies only to the macos version label Oct 5, 2020
@micheldebree micheldebree added the bug Something isn't working label Oct 5, 2020
micheldebree added a commit that referenced this issue Oct 5, 2020
@micheldebree
Cursor keys in tables without modifiers #71
0a29828 
Cursor keys in tables work only without modifiers,
so we can map up/down with modifiers to other functions
@micheldebree micheldebree mentioned this issue Oct 9, 2020
Merged
micheldebree added a commit that referenced this issue Oct 11, 2020
@micheldebree
Fixed bug with wrong keyboard action #71
d1e1821
micheldebree added a commit that referenced this issue Oct 11, 2020
@micheldebree
Cursor keys in tables without modifiers #71
434649d 
Cursor keys in tables work only without modifiers,
so we can map up/down with modifiers to other functions
micheldebree added a commit that referenced this issue Oct 11, 2020
@micheldebree
Fixed bug with wrong keyboard action #71
399f4e5
micheldebree added a commit that referenced this issue Oct 11, 2020
@micheldebree
Added fix for #71 to changelog
8f5ed1a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@micheldebree micheldebree

Labels
bug Something isn't working macos Applies only to the macos version
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cursor keys in tables without modifiers #71 Chordian/sidfactory2
1 participant
@micheldebree