Merge values not taking most frequent string

[ChrisMuir]

Seeing a bug in which the edit value assigned to a cluster is not the most frequent string in that cluster. Example:

refinr::key_collision_merge(c("cat bike", "bike cat", "bike cat"))
#> "cat bike" "cat bike" "cat bike"

I think the issue is within this line from file key_collision_merge_funcs.cpp:

// Get the string that appears most often in curr_vect.
String most_freq_string = curr_vect[which_max(table(curr_vect))];

I think the solution is to apply .sort() to curr_vect prior to calling table on it. Need to do some more testing.

[ChrisMuir]

Solution was to add this function to utils.cpp:

// Given a CharacterVector, return the string that appears most frequently.
// Ties are determined by the string that appears first alphabetically.
// [[Rcpp::export]]
String most_freq_str(CharacterVector x) {
  IntegerVector x_tab = table(x);
  CharacterVector tab_names = x_tab.attr("names");
  return(tab_names[which_max(x_tab)]);
}

The new function gets sourced during both key_collision_merge and n_gram_merge.

Going back to the example:

refinr::key_collision_merge(c("cat bike", "bike cat", "bike cat"))
#> "bike cat" "bike cat" "bike cat"