Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Compile Script #2061

Conversation

Marterich
Copy link
Contributor

This PR reworks the Compile script.

Addressed Issues:

  • The compile sometimes would fail and show a "file in use" error when writing to winutil.ps1
    -> This is addressed by assembling the whole script in memory and only writing to disk once (per created file)

Changes:

  • Add a Debug switch that only creates the auto-generated XAML files on disk if desired. If Debug isn't specified the files are removed from the disk (to avoid confusion with different versions of a newly compiled winutil script and old XAML files)
  • Add a visual progress bar detailing the compile status using Write-Progress
  • Add the header as a multiline string

@og-mrk
Copy link
Contributor

og-mrk commented Jun 10, 2024

Great improvements overall, happy to see xaml files not being created whenever compiling! 😎

This change and the .gitignore fix in PR #2051 should remove the worry of accidently adding compiled files by new users, not to mention the other nice changes you've made.

I'll try testing it when I've some spare time, well done @Marterich 😄

@ChrisTitusTech ChrisTitusTech merged commit 3cc84c4 into ChrisTitusTech:test-applications-2024-06 Jun 10, 2024
ChrisTitusTech added a commit that referenced this pull request Jun 10, 2024
* Simple improvements to 'applications.json' File (#2043)

* Replace Spaces with Tabs in 'applications.json' File

* Correct 'AFFiNE' App Entry's Winget ID from 'AFFiNE.stable' to 'ToEverything.AFFiNE' in 'applications.json' File

* Compile Winutil

* Tweaks (#2051)

* Fix Numlock toggle (#2044)

* Fix Numlock at login

* Compile Winutil

---------

Co-authored-by: ChrisTitusTech <ChrisTitusTech@users.noreply.github.com>

* Compile Winutil

* fix typo (#2041)

* Compile Winutil

* Update README.md

* * Fixed .getignore issues, it's it not enough to just add to gitgnore if it was already tracked by git it will be continued to be tracked by git, so you have to 'git rm' it
* Fixed ooshutup, there is no need to download configs, they are
  already compiled into winutil
+ Added a tweak to remove and disable Intel LMS, which have been
  identifed as a potential backdoor into Windows.

* Update winget.ps1

* + Added new release actions, every time we merge into main it will
  create a release by extracting the version fromwinutil.ps1 and setting
  all appropriate tags and versions

* fix merge

* add compile back in

* Update action to latest tools

* Ensure Compile is finished

---------

Co-authored-by: Chris Titus <contact@christitus.com>
Co-authored-by: ChrisTitusTech <ChrisTitusTech@users.noreply.github.com>
Co-authored-by: nikolan <94351312+nikolan123@users.noreply.github.com>
Co-authored-by: KonTy <KonTy@github.com>
Co-authored-by: Chris Titus <dfm.titus@gmail.com>

* Compile Winutil

* Rework Compile (#2061)

* Compile Winutil

---------

Co-authored-by: Mr.k <mineshtine28546271@gmail.com>
Co-authored-by: ChrisTitusTech <ChrisTitusTech@users.noreply.github.com>
Co-authored-by: KonTy <9524513+KonTy@users.noreply.github.com>
Co-authored-by: nikolan <94351312+nikolan123@users.noreply.github.com>
Co-authored-by: KonTy <KonTy@github.com>
Co-authored-by: Martin Wiethan <47688561+Marterich@users.noreply.github.com>
@Marterich Marterich deleted the CompileRework branch June 12, 2024 18:09
@ChrisTitusTech ChrisTitusTech added the skip-changelog Skip Change Logs label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skip Change Logs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants