Add AssetFile endpoint for retrieving file streams #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some documentation to the new endpoint.
apotek
requested review from
adamzimmermann
and removed request for
agarzola and
adamzimmermann
adamzimmermann
approved these changes
Jun 4, 2024
adamzimmermann
approved these changes
Jun 4, 2024
|
@adamzimmermann It looks like your approval doesn't count. @agarzola would you be able to rubber stamp this knowing that Adam and I have discussed this extensively and he approved it. |
agarzola
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #35
Description
This merge request adds a new Endpoint for retrieving file streams. Some file formats, such as watermarked assets, do not return a URL via the AssetLink Endpoint. In order to handle assets that have not been pre-generated and do not have a link, we need to use the AssetFile endpoint
/webapi/mediafile/assetfile/getassetfile_42R_v1.We also need to refactor the Response object to no longer assume all responses have JSON data. The Response object can contain a stream resource with binary data instead, so decoding the body will throw an exception.
This is a requirement/blocker for this
orange_damissue: https://www.drupal.org/project/orange_dam/issues/3451497