fix: PageCollector subscribing multiple times #241
Merged
+69
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
reviewed
Oct 1, 2025
Lightning00Blade
force-pushed
the
fix-data-collectors
branch
from
6493fc6 to
2ec9517
Compare
OrKoN
approved these changes
Oct 1, 2025
Lightning00Blade
force-pushed
the
fix-data-collectors
branch
from
e3a2a1b to
1f917e5
Compare
OrKoN
pushed a commit
that referenced
this pull request
Oct 1, 2025
🤖 I have created a release *beep* *boop* --- ## [0.6.0](chrome-devtools-mcp-v0.5.1...chrome-devtools-mcp-v0.6.0) (2025-10-01) ### Features * **screenshot:** add WebP format support with quality parameter ([#220](#220)) ([03e02a2](03e02a2)) * **screenshot:** adds ability to output screenshot to a specific pat… ([#172](#172)) ([f030726](f030726)) * support --accept-insecure-certs CLI ([#231](#231)) ([efb106d](efb106d)) * support --proxy-server CLI ([#230](#230)) ([dfacc75](dfacc75)) * support initial viewport in the CLI ([#229](#229)) ([ef61a08](ef61a08)) * support timeouts in wait_for and navigations ([#228](#228)) ([36e64d5](36e64d5)) ### Bug Fixes * **network:** show only selected request ([#236](#236)) ([73f0aec](73f0aec)) * PageCollector subscribing multiple times ([#241](#241)) ([0412878](0412878)) * snapshot does not capture Iframe content ([#217](#217)) ([ce356f2](ce356f2)), closes [#186](#186) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were setting the storage inside the first collect callback which mean that we double subscribed to the events.
This affected Network request and Console messages