Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi version #46

Merged
merged 5 commits into from
May 12, 2016
Merged

Multi version #46

merged 5 commits into from
May 12, 2016

Conversation

kdzwinel
Copy link
Contributor

@kdzwinel kdzwinel commented May 10, 2016

Review with w=1

Main page (versions on the left, no search):
1

Version index page (info about latest update moved from the main page):
2

Domain page (version mentioned in header):
3

Related to #4

{
"slug": "tot",
"name": "latest (tip-of-tree)"
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slug is used for URLs, folder & file names. name is used for titles and labels

@paulirish
Copy link
Member

paulirish commented May 12, 2016

Nice. the construction of this is a beauty.

I am hoping we can make a few changes.. let me if you think it sounds OK.

the tot protocol should be a default. so i would like to keep the left navigation of the tot protocol present as you land on the site. I guess that means we have a chooser control and the chooser defaults to tot?

I'd like to add another version if we can.. it's what's available via the upcoming nodejs debugger protocol.
Here's the protocol for that: https://gist.github.com/paulirish/1397e65098be1399752ec7587700ff4c
(it's basically the protocol at 4604d24 but only Runtime, Profiler, HeapProfiler, and Debugger domains.)

later on I think we'll add in the protocol for stable channel, but... for now this is good.

@kdzwinel
Copy link
Contributor Author

the tot protocol should be a default. so i would like to keep the left navigation of the tot protocol present as you land on the site. I guess that means we have a chooser control and the chooser defaults to tot?

So a chooser above the the left navigation, right? No problemo!

I'd like to add another version if we can.. it's what's available via the upcoming nodejs debugger protocol.

Absolutely! I've added steps for doing so to the readme. I'll add nodejs debugger protocol in a separate PR (after we merge this one).

@paulirish paulirish merged commit dfc2af2 into gh-pages May 12, 2016
@kdzwinel kdzwinel deleted the multi-version branch August 18, 2016 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants