-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi version #46
Multi version #46
Conversation
Fix searching. Update Readme.
{ | ||
"slug": "tot", | ||
"name": "latest (tip-of-tree)" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
slug
is used for URLs, folder & file names. name
is used for titles and labels
Nice. the construction of this is a beauty. I am hoping we can make a few changes.. let me if you think it sounds OK. the tot protocol should be a default. so i would like to keep the left navigation of the tot protocol present as you land on the site. I guess that means we have a chooser control and the chooser defaults to tot? I'd like to add another version if we can.. it's what's available via the upcoming nodejs debugger protocol. later on I think we'll add in the protocol for stable channel, but... for now this is good. |
So a chooser above the the left navigation, right? No problemo!
Absolutely! I've added steps for doing so to the readme. I'll add nodejs debugger protocol in a separate PR (after we merge this one). |
add node js protocol version
Review with w=1
Main page (versions on the left, no search):
Version index page (info about latest update moved from the main page):
Domain page (version mentioned in header):
Related to #4