feat: user-defined functions #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for providing user-defined functions. The parser is updated to allow any identifier to be a callable macro or function. A new optional argument to `evaluate` allows registering custom functions.
ChromeGG
force-pushed
the
feat/user-defined-functions
branch
from
1e17cfb
to
f41392a
Compare
|
Hi, thank you for your valuable contribution! I fixed some minor formatting issues and removed one redundant (IMO) test. The rest looks fine. Merging and releasing it! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This adds support for providing user-defined functions.
The parser is updated to allow any identifier to be a callable macro or function.
A new optional argument to
evaluateallows registering custom functions.I think I could follow this with support for the missing macros (
exists,has, etc) as well as some of the built-in functions likematches.Thank you!
Issue ticket number/link
I can open one if you think this needs more discussion there!
Checklist before requesting a review