This repository has been archived by the owner on May 6, 2022. It is now read-only.
Some minor fixes and refactoring. #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sputnikci
reviewed
Mar 13, 2017
|
|
||
| FunctionValueMap functionValues = null; | ||
|
|
||
| if (typeFunctions != null) { |
There was a problem hiding this comment.
[Checkstyle] ERROR: Nested if-else depth is 2 (max allowed is 1).
sputnikci
reviewed
Mar 13, 2017
| typeFunctions.sizeOfTransformations()); | ||
|
|
||
| //Only if we have functions, execute the following block | ||
| if (!functions.isEmpty()) { |
There was a problem hiding this comment.
[Checkstyle] ERROR: Nested if-else depth is 3 (max allowed is 1).
sputnikci
reviewed
Mar 13, 2017
| //Only if we have functions, execute the following block | ||
| if (!functions.isEmpty()) { | ||
| //first we do the transformations | ||
| if (typeFunctions.containsTransformations()) { |
There was a problem hiding this comment.
[Checkstyle] ERROR: Nested if-else depth is 4 (max allowed is 1).
sputnikci
reviewed
Mar 13, 2017
| for (ChronixTransformation transformation : typeFunctions.getTransformations()) { | ||
| timeSeries.applyTransformation(transformation, functionValues); | ||
| //then we apply aggregations | ||
| if (typeFunctions.containsAggregations()) { |
There was a problem hiding this comment.
[Checkstyle] ERROR: Nested if-else depth is 4 (max allowed is 1).
sputnikci
reviewed
Mar 13, 2017
| } | ||
| } | ||
| //finally the analyses | ||
| if (typeFunctions.containsAnalyses()) { |
There was a problem hiding this comment.
[Checkstyle] ERROR: Nested if-else depth is 4 (max allowed is 1).
sputnikci
reviewed
Mar 13, 2017
| // 1) the data is explicit requested as json | ||
| // 2) there are aggregations / transformations | ||
| // 3) there are matching analyses | ||
| if (dataAsJson || hasTransformationsOrAggregations(functionValues) || hasMatchingAnalyses(functionValues) || isJoined) { |
There was a problem hiding this comment.
[Checkstyle] ERROR: Nested if-else depth is 2 (max allowed is 1).
sputnikci
reviewed
Mar 13, 2017
| timeSeries.applyPairAnalysis((ChronixPairAnalysis) analysis, subQueryTimeSeries, functionValues); | ||
| } | ||
| }); | ||
| private void applyFunctions(SolrQueryRequest req, JoinFunction key, long queryStart, long queryEnd, Map.Entry<String, List<SolrDocument>> docs, ChronixType chronixType, QueryFunctions typeFunctions, FunctionValueMap functionValues, ChronixTimeSeries timeSeries) throws ParseException, IOException { |
There was a problem hiding this comment.
[Checkstyle] ERROR: More than 7 parameters (found 9).
3 similar comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.