Some Fixes. #77

FlorianLautenschlager · 2016-08-18T12:41:13Z

No description provided.

coveralls · 2016-10-04T12:06:32Z

Coverage remained the same at 100.0% when pulling c8305c5 on FlorianLautenschlager:master into 9db9766 on ChronixDB:master.

sputnikci · 2016-10-04T15:19:04Z

...ngestion-handler/src/main/java/de/qaware/chronix/solr/ingestion/ChronixIngestionHandler.java

+    @Override
+    public void handleRequestBody(SolrQueryRequest req, SolrQueryResponse rsp) throws Exception {
+        //Check: https://cwiki.apache.org/confluence/display/solr/Uploading+Data+with+Index+Handlers
+        //TODO: Handle the request


[Checkstyle] ERROR: Comment matches to-do format 'TODO:'.

sputnikci · 2016-10-04T15:19:04Z

...ngestion-handler/src/main/java/de/qaware/chronix/solr/ingestion/ChronixIngestionHandler.java

+
+        //2) Converter to time series
+        MetricTimeSeries ts = new MetricTimeSeries.Builder("cpu_load_short")
+                .attribute("host","server02")


[Checkstyle] ERROR: ',' is not followed by whitespace.

sputnikci · 2016-10-04T15:19:04Z

...ngestion-handler/src/main/java/de/qaware/chronix/solr/ingestion/ChronixIngestionHandler.java

+        //2) Converter to time series
+        MetricTimeSeries ts = new MetricTimeSeries.Builder("cpu_load_short")
+                .attribute("host","server02")
+                .attribute("region","us-west")


[Checkstyle] ERROR: ',' is not followed by whitespace.

sputnikci · 2016-10-04T15:19:04Z

...erver-query-handler/src/main/java/de/qaware/chronix/solr/query/analysis/AnalysisHandler.java

@@ -213,12 +212,12 @@ private static boolean hasTransformationsOrAggregations(FunctionValueMap functio
     * @throws ParseException if bad things happen
     * @throws IOException    if bad things happen
     */
-    private void applyAnalyses(SolrQueryRequest req, Iterable<ChronixAnalysis<MetricTimeSeries>> analyses, Function<SolrDocument, String> key, long queryStart, long queryEnd, Map.Entry<String, List<SolrDocument>> docs, MetricTimeSeries timeSeries, FunctionValueMap analysisAndValues) throws ParseException, IOException {
+    private void applyAnalyses(SolrQueryRequest req, Iterable<ChronixAnalysis> analyses, JoinFunction key, long queryStart, long queryEnd, Map.Entry<String, List<SolrDocument>> docs, MetricTimeSeries timeSeries, FunctionValueMap analysisAndValues) throws ParseException, IOException {


[Checkstyle] ERROR: More than 7 parameters (found 8).

sputnikci · 2016-10-04T15:19:05Z

...server-query-handler/src/main/java/de/qaware/chronix/solr/query/analysis/QueryEvaluator.java

        } else {
            LOGGER.info("{} is unknown. {} is ignored", type, type);
        }
    }

-    private static void addAggregation(QueryFunctions<MetricTimeSeries> result, FunctionType type, String[] arguments) {
+    private static void addStrace(QueryFunctions result, FunctionType type, String[] arguments) {
+        switch (type) {


[Checkstyle] ERROR: switch without "default" clause.

sputnikci · 2016-10-04T15:19:05Z

...server-query-handler/src/main/java/de/qaware/chronix/solr/query/analysis/QueryEvaluator.java

+    }
+
+    private static void addLsof(QueryFunctions result, FunctionType type, String[] arguments) {
+        switch (type) {


[Checkstyle] ERROR: switch without "default" clause.

sputnikci · 2016-10-04T15:19:05Z

...server-query-handler/src/main/java/de/qaware/chronix/solr/query/analysis/QueryEvaluator.java

@@ -203,7 +227,7 @@ private static void addAnalysis(QueryFunctions<MetricTimeSeries> result, Functio
        }
    }

-    private static void addTransformation(QueryFunctions<MetricTimeSeries> result, FunctionType type, String[] arguments) {
+    private static void addTransformation(QueryFunctions result, FunctionType type, String[] arguments) {


[Checkstyle] ERROR: NCSS for this method is 51 (max allowed is 50).

sputnikci · 2016-10-04T15:19:06Z

...r-query-handler/src/main/java/de/qaware/chronix/solr/query/analysis/SolrDocumentBuilder.java

+                //Performance optimization. Avoiding fine grained growing.
+                if (timestamps == null) {
+                    int size = ts.size();
+                    if (size < 1000) {


[Checkstyle] ERROR: Nested if-else depth is 2 (max allowed is 1).

sputnikci · 2016-10-04T15:19:06Z

...r-query-handler/src/main/java/de/qaware/chronix/solr/query/analysis/SolrDocumentBuilder.java

+                //Performance optimization. Avoiding fine grained growing.
+                if (timestamps == null) {
+                    int size = ts.size();
+                    if (size < 1000) {


[Checkstyle] ERROR: Nested if-else depth is 2 (max allowed is 1).

sputnikci · 2016-10-04T15:19:06Z

...uery-handler/src/main/java/de/qaware/chronix/solr/query/analysis/functions/FunctionType.java


    static {
-        Collections.addAll(AGGREGATIONS, AVG, MIN, MAX, DEV, P, SUM, COUNT, FIRST, LAST, RANGE, DIFF, SDIFF);
+        Collections.addAll(AGGREGATIONS, AVG, MIN, MAX, DEV, P, SUM, COUNT, FIRST, LAST, RANGE, DIFF, SDIFF,INTEGRAL);


[Checkstyle] ERROR: ',' is not followed by whitespace.

sputnikci · 2016-10-04T15:19:06Z

...-handler/src/main/java/de/qaware/chronix/solr/query/analysis/functions/aggregations/Avg.java


        //If it is empty, we return NaN
        if (timeSeries.size() <= 0) {
-            return Double.NaN;
+            functionValueMap.add(this,Double.NaN);


[Checkstyle] ERROR: ',' is not followed by whitespace.

sputnikci · 2016-10-04T15:19:06Z

...r/src/main/java/de/qaware/chronix/solr/query/analysis/functions/aggregations/Difference.java

        //If it is empty, we return NaN
        if (timeSeries.size() <= 0) {
-            return Double.NaN;
+            functionValueMap.add(this,Double.NaN);


[Checkstyle] ERROR: ',' is not followed by whitespace.

sputnikci · 2016-10-04T15:19:07Z

...r/src/main/java/de/qaware/chronix/solr/query/analysis/functions/aggregations/Difference.java

@@ -55,8 +49,8 @@ public double execute(MetricTimeSeries... args) {
        double firstValue = timeSeries.getValue(0);
        double lastValue = timeSeries.getValue(timeSeries.size() - 1);

-        //return the difference
-        return Math.abs(firstValue - lastValue);
+        functionValueMap.add(this,Math.abs(firstValue - lastValue));


[Checkstyle] ERROR: ',' is not followed by whitespace.

coveralls · 2016-10-04T15:19:21Z

Coverage remained the same at 100.0% when pulling aeb5787 on FlorianLautenschlager:master into 9db9766 on ChronixDB:master.

Florian Lautenschlager added 4 commits August 18, 2016 14:37

Fixes #76

c21831d

Fixes #82

a397901

Fixes #82

568b1a9

Fixes #82 - Added test case: time series with gaps.

40ca6bd

FlorianLautenschlager changed the title ~~Fixes #76~~ Some Fixes. Oct 1, 2016

Florian Lautenschlager added 7 commits October 4, 2016 08:34

Upgraded to Solr 6.2.1

837dd3d

Upgraded to Solr 6.2.1

585ef7a

Upgraded to Solr 6.2.1

d5f0a99

Upgraded to Solr 6.2.1

5b6de00

Large refactoring of the Chronix functions. Still some work to do.

97a9c47

Incremented version.

f38b11a

Set memory limit.

c8305c5

Florian Lautenschlager added 5 commits October 4, 2016 15:03

Distinct transformation, some refactoring.

612fa00

Functions are now final. Added integral aggregation.

979ae38

Skeleton for the ingestion handler.

d81b8ff

Skeleton for the ingestion handler.

2c11eed

Skeleton for the ingestion handler.

aeb5787

sputnikci reviewed Oct 4, 2016

View reviewed changes

FlorianLautenschlager merged commit 2d8dbcb into ChronixDB:master Oct 4, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Some Fixes. #77

Some Fixes. #77

FlorianLautenschlager commented Aug 18, 2016

coveralls commented Oct 4, 2016

sputnikci Oct 4, 2016

sputnikci Oct 4, 2016

sputnikci Oct 4, 2016

sputnikci Oct 4, 2016

sputnikci Oct 4, 2016

sputnikci Oct 4, 2016

sputnikci Oct 4, 2016

sputnikci Oct 4, 2016

sputnikci Oct 4, 2016

sputnikci Oct 4, 2016

sputnikci Oct 4, 2016

sputnikci Oct 4, 2016

sputnikci Oct 4, 2016

coveralls commented Oct 4, 2016 •

edited

Loading

Some Fixes. #77

Some Fixes. #77

Conversation

FlorianLautenschlager commented Aug 18, 2016

coveralls commented Oct 4, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Oct 4, 2016 • edited Loading

coveralls commented Oct 4, 2016 •

edited

Loading