Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChuckerInterceptor uses internal OkHttp APIs #52

Closed
ZacSweers opened this issue Jun 4, 2019 · 1 comment · Fixed by #53
Closed

ChuckerInterceptor uses internal OkHttp APIs #52

ZacSweers opened this issue Jun 4, 2019 · 1 comment · Fixed by #53
Assignees
@cortinico
Labels
bug Something isn't working

Comments

@ZacSweers
Copy link

ZacSweers commented Jun 4, 2019 •
edited
Loading

This will break with OkHttp 4
See jgilfelt/chuck#88
@cortinico cortinico self-assigned this Jun 4, 2019
@cortinico cortinico added the bug Something isn't working label Jun 4, 2019
cortinico added a commit that referenced this issue Jun 4, 2019
@cortinico
Remove usage of methods from okhttp3.internal
e240e0a 
Chucker was using one methods from the aforementioned package.
Those methods are risky to use as they may be broken between releases
and I'm cleaning them up.

Specifically the method `hasBody` has now been moved to an extension
function inside our internal package. This will make easier to migrate
to OkHttp 4.x as the above method has been removed.

Fixes #52
@cortinico cortinico mentioned this issue Jun 4, 2019
Merged
@cortinico
Copy link
Member

Hey @ZacSweers
Thanks for the report. Yeah we were using one method from okhttp3.internal inside the interceptor. I cleaned it up and now we should be good to go for OkHttp 4 👍

cortinico added a commit that referenced this issue Jun 11, 2019
@cortinico
Remove usage of methods from okhttp3.internal
4fe03e7 
Chucker was using one methods from the aforementioned package.
Those methods are risky to use as they may be broken between releases
and I'm cleaning them up.

Specifically the method `hasBody` has now been moved to an extension
function inside our internal package. This will make easier to migrate
to OkHttp 4.x as the above method has been removed.

Fixes #52
cortinico added a commit that referenced this issue Jun 12, 2019
@cortinico
Remove usage of methods from okhttp3.internal
714c080 
Chucker was using one methods from the aforementioned package.
Those methods are risky to use as they may be broken between releases
and I'm cleaning them up.

Specifically the method `hasBody` has now been moved to an extension
function inside our internal package. This will make easier to migrate
to OkHttp 4.x as the above method has been removed.

Fixes #52
@cortinico cortinico mentioned this issue Jul 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cortinico cortinico

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove usage of methods from okhttp3.internal ChuckerTeam/chucker
2 participants
@ZacSweers @cortinico