Deprecate Throwable related parts #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbuberen
commented
May 10, 2020
| @@ -163,4 +163,9 @@ internal class NotificationHelper(val context: Context) { | |||
| fun dismissErrorsNotification() { | |||
| notificationManager.cancel(ERROR_NOTIFICATION_ID) | |||
| } | |||
|
|
|||
| fun dismissNotifications() { | |||
There was a problem hiding this comment.
This fun is a subject to change after removing Throwable stuff.
cortinico
approved these changes
May 11, 2020
There was a problem hiding this comment.
Looks good to me. Minor changes that I will apply as well are:
- A note in the readme here https://github.com/ChuckerTeam/chucker#throwables-%EF%B8%8F
- A note on this line:
Even though this field is inside aninternalclass, its effect are public as a Notification channel will be created/used. We should probably note that this will go as well.
|
Good feedback. Thanks. I will address then in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Context
Since there is a plan to remove Throwable catching functionality in
4.xwe need to prepare users to not introduce breaking changes right away. This PR adds proper deprecation messages, which should both inform and help to switch to valid functions.📝 Changes
🛠️ How to test
Nothing special for testing. IDE should show suggestions if there is a replacement for deprecated function.