Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up #54

Merged
merged 1 commit into from
Jun 12, 2019
Merged

clean up #54

merged 1 commit into from
Jun 12, 2019

Conversation

Ashok-Varma
Copy link
Contributor

  1. some null checks amd spell checks
  2. headersToRedact to set from list
  3. taking advantage of android findViewById generic
  4. removed some unused code
  5. updated android gradle

@Ashok-Varma Ashok-Varma changed the title clean up 1 clean up Jun 10, 2019
@cortinico cortinico self-requested a review June 12, 2019 22:56
cortinico
cortinico approved these changes Jun 12, 2019
View reviewed changes
Copy link
Member

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contrib @Ashok-Varma
LGTM :)

@cortinico cortinico merged commit e7e5a20 into ChuckerTeam:develop Jun 12, 2019
@timnew timnew mentioned this pull request Jul 3, 2019
Closed
@cortinico cortinico added this to the 3.0.0 milestone Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortinico cortinico cortinico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Ashok-Varma @cortinico