-
-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export To Har #880
Export To Har #880
Conversation
Converting this to Draft. Feel free to ping me when you're done and need a review |
Go ahead @cortinico |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sneding this over.
You're missing several critical changes:
- Please fill in the pull request template.
- Update the
library-no-op
variant of the library as well. - Update the CHANGELOG with this change
- Add tests for this change.
library/src/main/kotlin/com/chuckerteam/chucker/api/ChuckerCollector.kt
Outdated
Show resolved
Hide resolved
library/src/main/kotlin/com/chuckerteam/chucker/internal/support/ExportFormat.kt
Outdated
Show resolved
Hide resolved
library/src/main/kotlin/com/chuckerteam/chucker/api/ChuckerCollector.kt
Outdated
Show resolved
Hide resolved
library/src/main/kotlin/com/chuckerteam/chucker/api/ChuckerCollector.kt
Outdated
Show resolved
Hide resolved
About tests: the |
library-no-op/src/main/kotlin/com/chuckerteam/chucker/api/ChuckerCollector.kt
Outdated
Show resolved
Hide resolved
library-no-op/src/main/kotlin/com/chuckerteam/chucker/api/ExportFormat.kt
Outdated
Show resolved
Hide resolved
library/src/main/kotlin/com/chuckerteam/chucker/api/ExportFormat.kt
Outdated
Show resolved
Hide resolved
Either two button side by side or a radio button work 👍 |
…kerCollector.kt Co-authored-by: Nicola Corti <corti.nico@gmail.com>
Seems like after adding a button there is now something to see. Would be good to have some screenshots. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff 👍 Thanks for taking a stance at this
@vbuberen can we merge this? |
Sure, looks good to me. |
Edited the export function that writes transaction data to a file and
returns a URI to access that file to also support .HAR format as a parameter.
📷 Screenshots
Internal Changes. The sample app layout has been updated to reflect the functionality: "Export to Har" button.
📄 Context
Closes #871
It adds support for writeTransactions to also export on .HAR format
📝 Changes
Pending.
📎 Related PR
None
🚫 Breaking
None
🛠️ How to test
It can be tested from the UI just adding the ExportFormat
⏱️ Next steps
No.