Extended Graphql support: Identify GraphQL requests fired as HTTP GET Requests. #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sGraphQLRequest property. Updates HttpTransactionDao.kt accordingly.
|
Thanks for this PR
I'd like to challenge the approach a bit as this looks like a bit of an overkill to me. Could we just detect if the path ends with |
|
@cortinico so I take it that we would also like to detect GQL request based on the operation names? |
|
@cortinico done. |
Yup we can have a combination of the two |
|
@cortinico I've included the changes that ID requests based on Operation name. |
cortinico
reviewed
Sep 17, 2022
library/src/main/kotlin/com/chuckerteam/chucker/internal/data/entity/HttpTransaction.kt
Outdated
Show resolved
Hide resolved
library/src/main/kotlin/com/chuckerteam/chucker/internal/support/RequestProcessor.kt
Outdated
Show resolved
Hide resolved
library/src/main/kotlin/com/chuckerteam/chucker/internal/ui/transaction/TransactionAdapter.kt
Show resolved
Hide resolved
…action.kt & HttpTransactionTuple.kt and all its dependencies.
…he `graphQLDetected` property
cortinico
reviewed
Sep 20, 2022
library/src/main/kotlin/com/chuckerteam/chucker/internal/data/entity/HttpTransaction.kt
Outdated
Show resolved
Hide resolved
library/src/main/kotlin/com/chuckerteam/chucker/internal/ui/transaction/TransactionAdapter.kt
Outdated
Show resolved
Hide resolved
library/src/main/kotlin/com/chuckerteam/chucker/internal/ui/transaction/TransactionAdapter.kt
Outdated
Show resolved
Hide resolved
sample/src/main/kotlin/com/chuckerteam/chucker/sample/GraphQlTask.kt
Outdated
Show resolved
Hide resolved
sample/src/main/kotlin/com/chuckerteam/chucker/sample/GraphQlTask.kt
Outdated
Show resolved
Hide resolved
sample/src/main/kotlin/com/chuckerteam/chucker/sample/GraphQlTask.kt
Outdated
Show resolved
Hide resolved
sample/src/main/kotlin/com/chuckerteam/chucker/sample/GraphQlTask.kt
Outdated
Show resolved
Hide resolved
sample/src/main/kotlin/com/chuckerteam/chucker/sample/GraphQlTask.kt
Outdated
Show resolved
Hide resolved
sample/src/main/kotlin/com/chuckerteam/chucker/sample/GraphQlTask.kt
Outdated
Show resolved
Hide resolved
cortinico
reviewed
Sep 20, 2022
sample/src/main/kotlin/com/chuckerteam/chucker/sample/GraphQlTask.kt
Outdated
Show resolved
Hide resolved
|
Thanks @cortinico. Any idea when do you plan to merge this PR? |
ArjanSM
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📷 Screenshots
📄 Context
Based on top #805 to support identification of GraphQL requests fired as
HTTP GET.Also the approach taken is as mentioned in #116
📝 Changes
🛠️ How to test
Tests have been updated.