Apply fixes from StyleCI #2927
Merged
Apply fixes from StyleCI #2927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
crossan007
added a commit
that referenced
this pull request
Nov 27, 2017
* closes #2474 * cart as client-side code in progress * empty to group works * add group to cart - client side object model API * Better cart view on SelectList page * move AddToPeopleCart out of GET param into CRMJSOM * start to move group/role selection to bootbox / CRMJSOM * Empty cart to group via JSOM * tweaks * use JSOM * update cart api * moving between groups to JSOM (not done) * Apply fixes from StyleCI * Move cart menu to JS. cleanup JSOM. * working group add / remove * cleanup * working move members between groups * Cart DTO * underp dto * more dto * dead code * cart dto * dto / api * working empty to group w/ role * remove CartToGroup.php with JSOM * underp personView Add to CArt * dto * fix test * fix tests * Apply fixes from StyleCI (#2927) * fix jsom methods * Fixes * Fixes * Apply fixes from StyleCI * prepare cart on page load * cleanup and fix null logic error * underp cart add/remove toggle * fix cartview logic * add cart code - no operational changes yet * fix failing test * Apply fixes from StyleCI * fix empty to group * fix cart to family * tweaks to featurecontext bootstrap * more tweaks * tests * fix last failing test * cart add and empty tests now pass * underp group view cart add * add datatype input validation to cart dto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request applies code style fixes from an analysis carried out by StyleCI.
For more information, click here.