Update README with hardened-indicator and aplly clj-kondo --lint recommendations
#35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lint recommendations
ercdude
approved these changes
Feb 8, 2023
There was a problem hiding this comment.
Nice cleanup.
Just a reminder that CI won't run for branches that is not dev or main. Maybe we should add release/* to test it as well.
In any case, tested locally and tests are passing. But for the future, let's avoid changing the source that it's not related with fixes related to the release directly to release/* branches.
For the next version, I will add release/v* to trigger the CI as well.
puchka
deleted the
misc/update-hardened-indicator-readme-clj-kondo-lint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
derivation-pathoptional parameterhardened-indicatorclj-kondo --lintrecommendations