Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Drive problems #133

Open
U-Go-7 opened this issue Feb 28, 2021 · 5 comments
Open

Google Drive problems #133

U-Go-7 opened this issue Feb 28, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@U-Go-7
Copy link

U-Go-7 commented Feb 28, 2021

Hi, when opening a link to a video in Google Drive, the black page with the video thumbnail loads, but when I click on the play button the video loads forever and never plays. I cannot whitelist because according to CleanLinks no link has been cleaned.
But as soon as I disable the Addon, I can watch the video.
Thanks

@Cimbali
Copy link
Owner

Cimbali commented Feb 28, 2021

Sorry about that, I will try to investigate but I'm not sure what's going on there.

@Cimbali Cimbali added the bug Something isn't working label Feb 28, 2021
@U-Go-7
Copy link
Author

U-Go-7 commented Feb 28, 2021 via email

@Cimbali
Copy link
Owner

Cimbali commented Mar 1, 2021

I don't think we do anything specific with Google, but to whitelist it you can create a new rule on the rules editing page (accessible eg via the options) with:

  • domain google.*
  • check matching sub domains
  • whitelist parameter .*
  • check allow javascript to modify links

Then click the save rule button.

@Cimbali
Copy link
Owner

Cimbali commented Mar 1, 2021

It might be that something in the url looks like an embedded url when it's not a valid url? An example page of Google shopping or Google drive where this happens would be most helpful.

@Cimbali
Copy link
Owner

Cimbali commented Mar 1, 2021

I found a random drive with some game demo: https://drive.google.com/drive/folders/1GSR0ThesQIYsPY2wn3qaigCpRzYjVn7k

Does this reproduce your issue ?

I managed to fix it with the following rules:

  • domain docs.google.com/ path ^/get_video_info$ whitelist parameters eurl
  • domain docs.google.com/ path ^/videoplayback$ whitelist ei and source
  • domain youtube.googleapis.com path ^/embed/$ remove parameters BASE_URL, BASE_YT_URL, iurl, reportabuseurl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants