Dashboard #31
Merged
Dashboard #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trades stored/updated in database, auto updating budget
…filled, dev/prod log level modified
Cinderella-Man
requested changes
Aug 30, 2019
|
Thanks @Soimil for your PR 👍 there's few improvements that I flagged in comments - could you please fix those? |
Soimil
commented
Aug 30, 2019
There was a problem hiding this comment.
No problem. I will do this asap. Thanks @Cinderella-Man for all suggestions.
|
|
||
| Ecto.Adapters.SQL.query!(Hefty.Repo, query).rows | ||
| |> Enum.group_by(fn [head | _tail] -> head end) | ||
| |> Enum.map(fn {symbol, [[_, _, losing], [_, _, gaining]]} -> %{String.to_atom("#{symbol}") => [gaining, losing]} end) |
There was a problem hiding this comment.
Instead of using String.to_atom("#{symbol}") it's popular to use :"#{symbol}"
Cinderella-Man
approved these changes
Aug 31, 2019
Cinderella-Man
pushed a commit
that referenced
this pull request
Sep 6, 2019
gaining / losing doughnut
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.