Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Motivation, issues
Adds a
role-arn
parameter to theecr-login
command to support STS role-assumption. This param is already supported in thesetup
command of thecircleci/aws-cli
orb it simply hasn't been exposed as part ofecr-login
yet.#158
Description
Add
role-arn
parameter toecr-login
command which is then passed to theaws-cli/setup
command.Add
role-arn
parameter to thebuild-image
command which is then passed to theecr-login
command.Add
role-arn
parameter to thebuild-and-push-image
command which is then passed to theecr-login
command.Add
role-arn
parameter to thebuild-and-push-image
job which is then passed to thebuild-and-push-image
command.