Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add role-arn param for ecr-login #170

Closed
wants to merge 1 commit into from

Conversation

bdehamer
Copy link

@bdehamer bdehamer commented Jan 6, 2022

Checklist

  • All new jobs, commands, executors, parameters have descriptions
  • Examples have been added for any significant new features
  • README has been updated, if necessary

Motivation, issues

Adds a role-arn parameter to the ecr-login command to support STS role-assumption. This param is already supported in the setup command of the circleci/aws-cli orb it simply hasn't been exposed as part of ecr-login yet.

#158

Description

Add role-arn parameter to ecr-login command which is then passed to the aws-cli/setup command.

Add role-arn parameter to the build-image command which is then passed to the ecr-login command.

Add role-arn parameter to the build-and-push-image command which is then passed to the ecr-login command.

Add role-arn parameter to the build-and-push-image job which is then passed to the build-and-push-image command.

@m477r1x
Copy link

m477r1x commented Feb 17, 2022

We are in desperate need of this, any change we can get this merged and release to the orb?

@brivu brivu mentioned this pull request Mar 1, 2022
@brivu
Copy link
Contributor

brivu commented Mar 16, 2022

Hey Cal!

This PR has been addressed and merged in this PR: #172

Cheers!
Brian

@brivu brivu closed this Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants