Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding enable-execute-command option to run_task #204

Merged
merged 2 commits into from
Aug 22, 2024
Merged

feat: Adding enable-execute-command option to run_task #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d73868f
feat: Adding enable-execute-command option to run_task
cheethoe Oct 31, 2023
f6ec18e
Merge branch 'master' into feat/support-execute-command-run-task
marboledacci Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/commands/run_task.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,12 @@ parameters:
"Specifies whether to enable Amazon ECS managed tags for the task."
type: boolean
default: false
enable_execute_command:
description: |
Determines whether to use the execute command functionality for the containers in this task. If true,
this enables execute command functionality on all containers in the task.
type: boolean
default: false
propagate_tags:
description: |
Specifies whether to propagate the tags from the task definition to
Expand Down Expand Up @@ -139,6 +145,7 @@ steps:
ORB_STR_OVERRIDES: <<parameters.overrides>>
ORB_STR_TAGS: <<parameters.tags>>
ORB_BOOL_ENABLE_ECS_MANAGED_TAGS: <<parameters.enable_ecs_managed_tags>>
ORB_BOOL_ENABLE_EXECUTE_COMMAND: <<parameters.enable_execute_command>>
ORB_BOOL_PROPAGATE_TAGS: <<parameters.propagate_tags>>
ORB_STR_CD_CAPACITY_PROVIDER_STRATEGY: <<parameters.capacity_provider_strategy>>
ORB_STR_PROFILE_NAME: <<parameters.profile_name>>
Expand Down
7 changes: 7 additions & 0 deletions src/jobs/run_task.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,12 @@ parameters:
"Specifies whether to enable Amazon ECS managed tags for the task."
type: boolean
default: false
enable_execute_command:
description: |
Determines whether to use the execute command functionality for the containers in this task. If true,
this enables execute command functionality on all containers in the task.
type: boolean
default: false
propagate_tags:
description: |
"Specifies whether to propagate the tags from the task definition to
Expand Down Expand Up @@ -167,6 +173,7 @@ steps:
overrides: << parameters.overrides >>
tags: << parameters.tags >>
enable_ecs_managed_tags: << parameters.enable_ecs_managed_tags >>
enable_execute_command: << parameters.enable_execute_command>>
propagate_tags: << parameters.propagate_tags >>
capacity_provider_strategy: << parameters.capacity_provider_strategy >>
profile_name: << parameters.profile_name >>
Expand Down
4 changes: 4 additions & 0 deletions src/scripts/run_task.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,10 @@ if [ "$ORB_BOOL_ENABLE_ECS_MANAGED_TAGS" == "1" ]; then
echo "Setting --enable-ecs-managed-tags"
set -- "$@" --enable-ecs-managed-tags
fi
if [ "$ORB_BOOL_ENABLE_EXECUTE_COMMAND" == "1" ]; then
echo "Setting --enable-execute-command"
set -- "$@" --enable-execute-command
fi
if [ "$ORB_BOOL_PROPAGATE_TAGS" == "1" ]; then
echo "Setting --propagate-tags"
set -- "$@" --propagate-tags "TASK_DEFINITION"
Expand Down