Add arm64 Support #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 7, 2023
BytesGuy
added a commit
to CircleCI-Public/cimg-node
that referenced
this pull request
Jul 10, 2023
# Description Add arm64 support to the cimg/node image by using buildx to build multi arch images. The majority of the work actually lives in the cimg-shared repo which is where the build commands are generated: CircleCI-Public/cimg-shared#83 CircleCI-Public/cimg-shared#84 The main change to the Dockerfile here is an architecture check and switch to the `USER` directive. `sudo` in buildx builds generally causes errors when running Docker on linux. See also changes to cimg-orb: https://github.com/CircleCI-Public/cimg-orb/pull/51 Note: The browsers variant does not build for arm64, only amd64, due to a limitation with selenium server. We will address this in the future, once arm64 support is rolled out to the majority of images Test build with buildx: https://app.circleci.com/pipelines/github/CircleCI-Public/cimg-node/1419/workflows/daea85da-b14a-479b-adc9-d9c358135e16/jobs/1486 # Reasons To build multi architecture images and allow cimg/node to run on arm64 natively # Checklist Please check through the following before opening your PR. Thank you! - [x] I have made changes to the `Dockerfile.template` file only - [x] I have not made any manual changes to automatically generated files - [x] My PR follows best practices as described in the [contributing guidelines](CONTRIBUTING) - [x] (Optional, but recommended) My commits are [signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits)
4 tasks
BytesGuy
added a commit
to CircleCI-Public/cimg-python
that referenced
this pull request
Jul 11, 2023
# Description Add arm64 support to the cimg/python image by using buildx to build multi arch images. The majority of the work actually lives in the cimg-shared repo which is where the build commands are generated: CircleCI-Public/cimg-shared#83 CircleCI-Public/cimg-shared#84 CircleCI-Public/cimg-shared#85 The main change to the Dockerfile here is the switch to the `USER` directive. `sudo` in buildx builds generally causes errors when running Docker on linux. See also changes to cimg-orb: https://github.com/CircleCI-Public/cimg-orb/pull/51 **Notes for Python:** The builds with buildx are _super slow_, so I am not 100% happy with the current build workflow for this image in particular. Ideally we need to split this into building on native platforms and combine the manifest, but for now this current solution may work. --- Note: The browsers variant does not build for arm64, only amd64, due to a limitation with selenium server. We will address this in the future, once arm64 support is rolled out to the majority of images Test build with buildx: https://app.circleci.com/pipelines/github/CircleCI-Public/cimg-python/569/workflows/8cde5db1-d47b-47f1-ba7c-13b343a1879d # Reasons To build multi architecture images and allow cimg/python to run on arm64 natively # Checklist Please check through the following before opening your PR. Thank you! - [x] I have made changes to the `Dockerfile.template` file only - [x] I have not made any manual changes to automatically generated files - [x] My PR follows best practices as described in the [contributing guidelines](CONTRIBUTING) - [x] (Optional, but recommended) My commits are [signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds initial support for arm64
arm64=1is added to the imagemanifestfile, thegen-dockerfiles.shscript will default to create buildx commandsNote: Right now browser variants are skipped for arm64 due to issues with Selenium server. This will be addressed later