Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip installation if installed version is newer #77

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

EricRibeiro
Copy link
Contributor

Checklist

  • All new jobs, commands, executors, parameters have descriptions
  • Examples have been added for any significant new features
  • README has been updated, if necessary

Motivation, issues

Closes #73

Description

This PR adds an extra check for the CLI installation. If the installed version is newer than whatever is retrieved from the release notes, we skip the installation.

@EricRibeiro EricRibeiro requested a review from a team as a code owner July 27, 2023 21:09
Copy link

@brivu brivu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@brivu brivu merged commit 637a5b8 into master Jul 27, 2023
2 checks passed
@brivu brivu deleted the fix/version-installation branch July 27, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gcp-cli/setup improperly attempts to uninstall newer versions when requesting latest version
2 participants