enhancement for node_mgmt_epg_to_contract (DCNE-87) #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinross
requested review from
lhercot,
shrsr,
akinross,
sajagana,
samiib,
gmicol and
anvitha-jain
github-actions
bot
changed the title
Ziaf007
force-pushed
the
node_mgmt_epg_to_contract
branch
from
9010dbf
to
820f4cc
Compare
Ziaf007
force-pushed
the
node_mgmt_epg_to_contract
branch
from
820f4cc
to
2873077
Compare
samiib
requested changes
Oct 25, 2024
| argument_spec.update(aci_annotation_spec()) | ||
| argument_spec.update( | ||
| contract_type=dict(type="str", choices=["consumer", "provider", "taboo", "interface"], required=True), | ||
| epg_type=dict(type="str", aliases=["type"], choices=["in_band","out_of_band"], required=True) |
There was a problem hiding this comment.
Suggested change
| epg_type=dict(type="str", aliases=["type"], choices=["in_band","out_of_band"], required=True) | |
| epg_type=dict(type="str", aliases=["type"], choices=["in_band","out_of_band"], required=True), |
This should fix the black formatting error. Please run black -l 159 to format this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-) Added node_mgmt_epg_to_contract module
-) Test.yml still pending, working on it.
DCNE-87