Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RPC output to be decoded to entity; Single instance of list in read output needs to be returned as a list #459

Merged
3 commits merged into from May 25, 2017

Conversation

ghost
Copy link

@ghost ghost commented May 25, 2017

Fixes #332
Fixes #457

@ghost ghost added the in progress label May 25, 2017
@codecov-io
Copy link

codecov-io commented May 25, 2017

Codecov Report

Merging #459 into master will decrease coverage by 0.13%.
The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #459      +/-   ##
==========================================
- Coverage   83.58%   83.44%   -0.14%     
==========================================
  Files         109      109              
  Lines       13104    13116      +12     
  Branches     1923     1932       +9     
==========================================
- Hits        10953    10945       -8     
- Misses       1593     1612      +19     
- Partials      558      559       +1
Impacted Files Coverage Δ
sdk/python/core/ydk/services/netconf_service.py 88.7% <100%> (+2.14%) ⬆️
sdk/python/core/ydk/services/executor_service.py 100% <100%> (ø) ⬆️
...dk/python/core/tests/test_sanity_service_errors.py 76.54% <100%> (ø) ⬆️
sdk/python/core/tests/test_sanity_netconf.py 96.12% <100%> (ø) ⬆️
sdk/python/core/tests/test_sanity_rpc.py 90.56% <100%> (ø) ⬆️
sdk/python/core/ydk/providers/_decoder.py 68.48% <35.71%> (-2.25%) ⬇️
sdk/python/core/ydk/providers/_provider_plugin.py 72.3% <63.63%> (-0.17%) ⬇️
ydkgen/printer/python/namespace_printer.py 95.71% <77.77%> (-2.7%) ⬇️
ydkgen/builder/test_case/test_cases_builder.py 77.69% <0%> (-4.32%) ⬇️
ydkgen/builder/test_case/test_value_builder.py 91.21% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49cdeed...dc55713. Read the comment docs.

@ghost ghost merged commit 732f412 into CiscoDevNet:master May 25, 2017
@ghost ghost removed the in progress label May 25, 2017
ylil93 pushed a commit to ylil93/ydk-gen that referenced this pull request Sep 14, 2017
…ad output needs to be returned as a list (CiscoDevNet#459)

* Fix rpc output to be decoded into entity

* Fix incorrect decoding when read list only has one element
ylil93 pushed a commit to ylil93/ydk-gen that referenced this pull request Sep 14, 2017
…ad output needs to be returned as a list (CiscoDevNet#459)

* Fix rpc output to be decoded into entity

* Fix incorrect decoding when read list only has one element
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant