crud update fix #481
Merged
crud update fix #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
suggested changes
Jun 23, 2017
| @@ -206,7 +206,7 @@ def _create_update_entity_filter(self, entity): | |||
| raise YPYServiceError(error_msg=err_msg) | |||
|
|
|||
| module = importlib.import_module(entity._meta_info().pmodule_name) | |||
| update_filter = getattr(module, entity._meta_info().name)() | |||
| update_filter = operator.attrgetter(entity._meta_info().name)(module)() | |||
There was a problem hiding this comment.
Thanks for your contribution. Need to import the operator module. This is causing the CI to fail.
There was a problem hiding this comment.
Added the change in the same commit. Thanks.
Codecov Report
@@ Coverage Diff @@
## master #481 +/- ##
==========================================
- Coverage 84.01% 83.99% -0.03%
==========================================
Files 109 109
Lines 13050 13051 +1
Branches 1885 1885
==========================================
- Hits 10964 10962 -2
- Misses 1566 1572 +6
+ Partials 520 517 -3
Continue to review full report at Codecov.
|
psykokwak4
approved these changes
Jun 26, 2017
ghost
approved these changes
Jun 27, 2017
ghost
merged commit 
|
Thanks for your contribution! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update operation in crud_service.py has a _create_update_entity_filter function, which tries to read the entity in the module, but the update_filter fails to fetch the nested class instance, because of the behavior of python getattr function, which does not support consecutive attribute retrievals.
The fix for this issue can be to use the operator.attrgetattr() python function instead.