-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Golang services #605
Golang services #605
Conversation
ylil93
commented
Oct 18, 2017
- netconf services, tests, doc
- executor services, tests, doc
- logging wrapper
- fixed bugs in api gen
- fixed bugs in testing
- missing CopyConfig() and Validate()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this change, Lily! Looks good. Just one minor comment.
sdk/go/core/ydk/path/path.go
Outdated
@@ -406,17 +508,17 @@ func getDataNodeFromEntity(state *types.State, entity types.Entity, rootSchema C | |||
func walkChildren(state *types.State, entity types.Entity, dataNode C.DataNode) { | |||
children := entity.GetChildren() | |||
|
|||
fmt.Printf("Got %d entity children\n", len(children)) | |||
ydk.YLogInfo(fmt.Sprintf("Got %d entity children", len(children))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be YLogDebug
instead of YLogInfo
. Info
should only be used for end-user relevant logs. These messages are more relevant for ydk developers, not end user.
sdk/go/core/ydk/path/path.go
Outdated
|
||
for childName := range children { | ||
|
||
fmt.Printf("Lookin at entity child '%s'\n", children[childName].GetSegmentPath()) | ||
ydk.YLogInfo(fmt.Sprintf("Looking at entity child '%s'", children[childName].GetSegmentPath())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above. These should be YLogDebug
instead of YLogInfo
. Info
should only be used for end-user relevant logs. These messages are more relevant for ydk developers, not end user.
made the suggested changes |
Codecov Report
@@ Coverage Diff @@
## golang #605 +/- ##
======================================
Coverage 73.8% 73.8%
======================================
Files 104 104
Lines 10271 10271
Branches 1359 1359
======================================
Hits 7581 7581
Misses 2431 2431
Partials 259 259
Continue to review full report at Codecov.
|