Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issues 627 and 682. #691

Merged
8 commits merged into from
Feb 21, 2018
Merged

Fixed issues 627 and 682. #691

8 commits merged into from
Feb 21, 2018

Conversation

ygorelik
Copy link
Collaborator

@ygorelik ygorelik commented Feb 21, 2018

Fixes #627, Fixes #682

@codecov
Copy link

codecov bot commented Feb 21, 2018

Codecov Report

Merging #691 into master will increase coverage by 0.11%.
The diff coverage is 89.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #691      +/-   ##
==========================================
+ Coverage   74.22%   74.33%   +0.11%     
==========================================
  Files         104      104              
  Lines       10470    10533      +63     
  Branches     1467     1471       +4     
==========================================
+ Hits         7771     7830      +59     
- Misses       2397     2399       +2     
- Partials      302      304       +2
Impacted Files Coverage Δ
...k/python/core/ydk/path/sessions/netconf_session.py 69.23% <ø> (ø) ⬆️
sdk/python/core/tests/test_sanity_netconf.py 91.77% <100%> (+1.92%) ⬆️
sdk/python/core/tests/test_sanity_path.py 99.05% <100%> (+0.29%) ⬆️
sdk/python/core/ydk/services/netconf_service.py 68.96% <41.66%> (-3.19%) ⬇️
ydkgen/api_model.py 78.24% <0%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 785fe0e...6d0b83c. Read the comment docs.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, @ygorelik !

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant