Fix for query_dn method with "hierarchy=True" #1
Conversation
prvashis
commented
May 24, 2016
prvashis
commented
- Fix for "query_dn" method failing when parameter "hierarchy=True".
- Added checks to validate that SDK allows connection only to IMC Servers.
- PEP8 changes.
|
|
|
@prvashis can you investigate the 2 code smells above and update. Cyclic dependency specifically. |
|
@prvashis I investigated the cyclic import issue - it is a false positive due to a bug in pylint - pylint-dev/pylint#850 |
| if len(method_response.out_config.child) == 0: | ||
| return mo_list | ||
| else: | ||
| if len(method_response.out_configs.child) == 0: |
There was a problem hiding this comment.
@prvashis : does imc support out_configs? if not please remove else block.
There was a problem hiding this comment.
configResolveClass API returns "outConfigs" where as configResolveDn API returns "outConfig" , because of this we have put the above if else statement.
There was a problem hiding this comment.
@prvashis from what I remember for ucsm, configResolveClass = > outconfig, configResolveClasses => outConfigs.. so, you mean IMC is different?
There was a problem hiding this comment.
@vvb Yes in IMC we have "configResolveClass","configResolveChildren" and "configResolveDn".
We don't have configResolveClasses and configResolveDns in IMC.
configResolveDn returns "outConfig"
Whereas configResolveClass and configResolveChildren returns "outConfigs"
There was a problem hiding this comment.
@prvashis I stand corrected.. I think configResolveClass in ucsm also returns outConfigs, as it could return multiple Mos, even if one class was mentioned.
PEP8 changes. Added checks to validate that SDK allows connection only to IMC Servers. Incorporated code review comments. Incorporated comments on Dn fix issue. Incorporated review comments.
|
@prvashis LGTM, thanks for the patience in resolving all the review comments. |
…ens to master * commit '8c1782bb958f8d40cba81aa2f383670c0d6e113c': unit tests for bios tokens api correcting the verbs for the MOs correcting the version for M5 schema to 311d Bios Token APIs and generated helper file
