Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move lane connection manager to sub folder. #1545

Merged
merged 3 commits into from
Apr 27, 2022
Merged

Conversation

kianzarrin
Copy link
Collaborator

@kianzarrin kianzarrin commented Apr 24, 2022

preparation for #354:

  • renamed the namespace/folder LaneConnectionManagerData to LaneConnection.
  • moved LaneConnectionManager there.

in the next phase I will put SubLaneConnectionManager in the same place. there will be 2 instances of SubLaneConnectionManager. one for car and one for track.

TMPE.zip

Note: this PR has no functional change. its just moving files. But since it appears that I have changed a lot I decided not to mix it with my real changes to make review easier.

@kianzarrin kianzarrin self-assigned this Apr 24, 2022
@kianzarrin kianzarrin mentioned this pull request Apr 24, 2022
@kianzarrin
Copy link
Collaborator Author

I need to run some tests.

@kianzarrin kianzarrin marked this pull request as ready for review April 25, 2022 05:19
@kianzarrin
Copy link
Collaborator Author

test works.

Copy link
Collaborator

@kvakvs kvakvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking fine

Copy link
Contributor

@chameleon-tbn chameleon-tbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kianzarrin kianzarrin added this to the 11.6.5.3 milestone Apr 25, 2022
Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

If this is waiting for 11.6.5.3 (as stated in sidebar) please add Do not merge label

(I'm fine with this going in 11.6.5.2 btw)

@originalfoo originalfoo added code cleanup Refactor code, remove old code, improve maintainability LANE ROUTING Feature: Lane arrows / connectors labels Apr 25, 2022
@kianzarrin kianzarrin added the DO NOT MERGE YET Don't merge this PR, even if approved, until further notice label Apr 25, 2022
@kianzarrin kianzarrin merged commit 2f7d01e into master Apr 27, 2022
@kianzarrin kianzarrin deleted the 354-prepare-cleaned branch April 27, 2022 20:10
@originalfoo originalfoo removed the DO NOT MERGE YET Don't merge this PR, even if approved, until further notice label Apr 27, 2022
originalfoo added a commit that referenced this pull request May 22, 2022
- [Meta] This release adds a new language, updates translations, and improves lane routing
- [New] Veitnamese translation #1551 (DucAnhLam)
- [Updated] Separate road and track lane routing #1550 #1546 #1545 #354 (kianzarrin)
- [Updated] Translations for multiple languages #1551 #1344 (Nguyễn Tài Đức, OldEj, AduitSSH, Chamëleon, 문주원, krzychu124, shg166, John Lok Ho, Márcio Saeger, DucAnhLam, DNSE, Arne Peirs, Neoone, Fatih YILDIRIM, Zeldslayer, GiorgioHerbie, krzychu124)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup Refactor code, remove old code, improve maintainability LANE ROUTING Feature: Lane arrows / connectors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants