Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locale key updates #1551

Merged
merged 11 commits into from
May 22, 2022
Merged

Locale key updates #1551

merged 11 commits into from
May 22, 2022

Conversation

originalfoo
Copy link
Member

@originalfoo originalfoo commented Apr 27, 2022

Note: Testing should be done with a DEBUG build (missing locale string pilcrows aren't shown in TEST/RELEASE builds).

Fixes #1344:

  • Added new locale keys to Crowdin
  • Included latest translations from Crowdin
  • Updated few locale keys in code to match simplified keys on Crowdin
  • Updated despawn button to use custom component (same as other buttons)
  • Localise What's New button in mod options
  • Localise title bar of What's New panel
  • Localise pathfinder update message

Some additional future work is tracked in #1567

New languages (some translations already introduced in earlier PRs):

List of contributors in this batch of updates:

Updated few locale keys to match simplified keys on Crowdin.

Also updated a despawn button to use custom component.
@originalfoo originalfoo added Localisation Localised text and features DO NOT MERGE YET Don't merge this PR, even if approved, until further notice Settings Road config, mod options, config xml labels Apr 27, 2022
@originalfoo originalfoo added this to the 11.6.5.3 milestone Apr 27, 2022
@originalfoo originalfoo self-assigned this Apr 27, 2022
@originalfoo originalfoo added the UI User interface updates label May 9, 2022
@originalfoo
Copy link
Member Author

image

@krzychu124
Copy link
Member

I've updated translation scheme files (Vietnamese should be available vi), approved and improved some incorrectly translated strings (mostly Italian 😄 )

@krzychu124
Copy link
Member

Is there are chance about merging it till e.g. this weekend, so we could push it to Test and then release hot-fixed 11.6.5.2 to Stable to move away from the current broken/not switchable state (Test <-> Stable)?
Since @kianzarrin working on UI for lane connector to separate tracks from road (or even finished if I see correctly) maybe the version should be 11.6.6.0 instead of current 11.6.5.3?
It's just a thought to discuss further since would be nice to speed up development and move forward a little bit faster. Heh, my todo list is constantly growing 😂

Next up we have @Elesbaan70 persistence thingy which could be release along with Airports DLC support - not much left to add there, and I thought about using new persistence for serializing passenger airplane size restrictions as any modification to current serialization solution will break compatibility again and complicate things...

Persistence and Airports DLC improvements as a 11.7.x or maybe even better, as v.12 if we generate more changes? I mean.. persistence change is itself a big change 😅
I'll try to squeeze few priority behavior improvements there too or minor improvements for ParkingAI (I've done few experiments already and results are promising - is slightly better than before, without much effort like e.g.: rewriting the logic) I remember you also started working on overlays so it could nicely fit into "big changes" release.

@originalfoo
Copy link
Member Author

Yup, will try and get this done tomorrow. Sorry for delay, been spending lots of time this week arguing with lawyers about changing my legal name to "State Funded Terrorism" which they seem to have issue with yet they're finding it difficult to explain why without accepting that the entire legal system is complete bullshit.

@originalfoo originalfoo removed the DO NOT MERGE YET Don't merge this PR, even if approved, until further notice label May 21, 2022
@originalfoo
Copy link
Member Author

ready for testing

originalfoo added a commit that referenced this pull request May 22, 2022
- [Meta] This release adds a new language, updates translations, and improves lane routing
- [New] Veitnamese translation #1551 (DucAnhLam)
- [Updated] Separate road and track lane routing #1550 #1546 #1545 #354 (kianzarrin)
- [Updated] Translations for multiple languages #1551 #1344 (Nguyễn Tài Đức, OldEj, AduitSSH, Chamëleon, 문주원, krzychu124, shg166, John Lok Ho, Márcio Saeger, DucAnhLam, DNSE, Arne Peirs, Neoone, Fatih YILDIRIM, Zeldslayer, GiorgioHerbie, krzychu124)
Copy link
Collaborator

@kvakvs kvakvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@krzychu124
Copy link
Member

Missing key (we can add later) :/
image

/// Not related to this PR but still something we should fix but can live with it

Slider is not disabled in the main menu
image

The same for speed limit themes + checkbox - shows warning that settings cannot be changed in main menu so at least that but both are stored in the global config so they could be changed, just skipped regular update and texture generation (will be generated at load time)
image

No vertical scroll at Keybinds tab (does not show up and work for some weird reason 🤷‍♂️ )

IMO it's still good enough to push to Stable, anyways

Copy link
Member

@krzychu124 krzychu124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in game, Vietnamese lang works as it should, didn't notice any broken things with regards to translation 👍

@originalfoo
Copy link
Member Author

Missing key (we can add later) :/

Yup, tracked in #1567

Slider is not disabled in the main menu

I think they're disabled but just not 'dimmed'.

The same for speed limit themes + checkbox

Those are acutally global options, although I'm not sure why. Personally I feel it would make more sense to have those as savegame options, but they were already done as global options prior to me and Kian reworking the UI components. We could probably look in to that with the new persistence stuff?

@originalfoo originalfoo merged commit ee6cfee into master May 22, 2022
@originalfoo originalfoo deleted the locale-key-updates branch May 22, 2022 02:58
@krzychu124
Copy link
Member

I think they're disabled but just not 'dimmed'.

nope, I see it is reporting changes and enabled the dls checkbox despite it was disabled

@originalfoo
Copy link
Member Author

I think they're disabled but just not 'dimmed'.

nope, I see it is reporting changes and enabled the dls checkbox despite it was disabled

I've added a note about that to #1567

@originalfoo originalfoo mentioned this pull request May 22, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Localisation Localised text and features Settings Road config, mod options, config xml UI User interface updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translations for 11.6.5 (localisation / locale / crowdin)
3 participants