-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lane connection "SUB" manager #1546
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
originalfoo
added
code cleanup
Refactor code, remove old code, improve maintainability
LANE ROUTING
Feature: Lane arrows / connectors
labels
Apr 25, 2022
originalfoo
approved these changes
Apr 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I also checked Roundabout Builder mod and it doesn't use any of the lane connections stuff so should be unaffected by this and planned future PRs.
Merged
kianzarrin
added
the
DO NOT MERGE YET
Don't merge this PR, even if approved, until further notice
label
Apr 25, 2022
4 tasks
kvakvs
approved these changes
Apr 26, 2022
originalfoo
removed
the
DO NOT MERGE YET
Don't merge this PR, even if approved, until further notice
label
Apr 27, 2022
originalfoo
added a commit
that referenced
this pull request
May 22, 2022
- [Meta] This release adds a new language, updates translations, and improves lane routing - [New] Veitnamese translation #1551 (DucAnhLam) - [Updated] Separate road and track lane routing #1550 #1546 #1545 #354 (kianzarrin) - [Updated] Translations for multiple languages #1551 #1344 (Nguyễn Tài Đức, OldEj, AduitSSH, Chamëleon, 문주원, krzychu124, shg166, John Lok Ho, Márcio Saeger, DucAnhLam, DNSE, Arne Peirs, Neoone, Fatih YILDIRIM, Zeldslayer, GiorgioHerbie, krzychu124)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
API
API for external mods
code cleanup
Refactor code, remove old code, improve maintainability
LANE ROUTING
Feature: Lane arrows / connectors
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
phase 2 preparation for #354. continuation of #1545
TMPE.zip
This PR has no functional change. Just moving code from `Lane Connection manager to.
In this PR there is only one instance of the SUB manager which handles both road/track connections. This is just a preparation for the next PR where There will be 2 sub managers and I will change the code Like this.
Next PR will be final and will make major changes to persistency/UI code. To avoid a giant PR I decided to break it down into multiple PRs.
Compatibility with external mods:
I fixed a bug in
TMPE.API
that failed to getManagersFactory
. Now it is working.For backward compatibility with my mods I did not remove implementations of
ILaneConnectionManager
fromLaneConnectoinManager
even if I didn't call them fromTMPE
.used TMPE API in my mods:
HUT-DCR.zip
EDIT: I cherry picked the API fix and created #1548. I need this hotfix in both Test/Stable before I can upload my mods to WS.