fix: create payment if any of the chargeable signups is attending

City-of-Helsinki · Jun 7, 2024 · 2d67dab · 2d67dab
1 parent ef389cc
commit 2d67dab
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/src/domain/signupGroup/__tests__/utils.test.ts b/src/domain/signupGroup/__tests__/utils.test.ts
@@ -841,14 +841,14 @@ describe('shouldCreatePayment', () => {
     [[freeSignup], false],
     [[freeSignupInWaitingList], false],
     [[chargeableSignup, chargeableSignup], true],
-    [[chargeableSignup, chargeableSignupInWaitingList], false],
+    [[chargeableSignup, chargeableSignupInWaitingList], true],
     [[chargeableSignup, freeSignup], true],
-    [[chargeableSignup, freeSignupInWaitingList], false],
+    [[chargeableSignup, freeSignupInWaitingList], true],
     [[chargeableSignupInWaitingList, freeSignup], false],
     [[chargeableSignupInWaitingList, freeSignupInWaitingList], false],
     [[freeSignup, freeSignupInWaitingList], false],
   ])(
-    'should return true if any signup is chargeable and all signups are attending',
+    'should return true if any chargeable signup is attending',
     (signups, createPayment) => {
       expect(shouldCreatePayment(priceGroupOptions, signups)).toEqual(
         createPayment

diff --git a/src/domain/signupGroup/utils.ts b/src/domain/signupGroup/utils.ts
@@ -403,8 +403,10 @@ export const shouldCreatePayment = (
   signups: SignupFormFields[]
 ) =>
   featureFlagUtils.isFeatureEnabled('WEB_STORE_INTEGRATION') &&
-  calculateTotalPrice(priceGroupOptions, signups) > 0 &&
-  signups.every((su) => !su.inWaitingList);
+  calculateTotalPrice(
+    priceGroupOptions,
+    signups.filter((su) => !su.inWaitingList)
+  ) > 0;
 
 export const canEditSignupGroup = (signupGroup: SignupGroup) =>
   signupGroup.is_created_by_current_user ||