Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LINK-1530 | Improve phone number validation #65

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

jorilindell
Copy link
Contributor

@jorilindell jorilindell commented Sep 7, 2023

Description

Improve phone number validation to allow e.g. +358 44 1234 567 which is used as placeholder text

Closes

LINK-1530

@jorilindell jorilindell requested a review from a team September 7, 2023 11:40
@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2023

Codecov Report

Merging #65 (015f687) into develop (24d1815) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop      #65   +/-   ##
========================================
  Coverage    99.65%   99.65%           
========================================
  Files          128      128           
  Lines         2299     2299           
  Branches       364      364           
========================================
  Hits          2291     2291           
  Misses           8        8           
Files Changed Coverage Δ
src/utils/validationUtils.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@mikkojamG mikkojamG self-assigned this Sep 8, 2023
@jorilindell jorilindell merged commit f87ebc2 into develop Sep 8, 2023
5 checks passed
@jorilindell jorilindell deleted the fix/LINK-1530-phone-validation branch September 8, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants