-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1389/content + translation updates #1409
Conversation
✅ Deploy Preview for detroit-public-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for detroit-partners-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for detroit-storybook-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
One translation concern that came out of this was that Markdown files when presented right to left are showing the linked phone numbers from right to left as well which I don't believe is correct based on this. Has this issue come up before? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ColinBuyck I don't think we've chatted about that issue before, I would love to make a separate ticket for that since it may touch things outside of translations, could you spin that up?
@emilyjablonski Yep! |
Pull Request Template
Issue Overview
This PR addresses #1389
Description
This PR includes both content updates and translations based on the Ad Hoc Translations tab of https://docs.google.com/spreadsheets/d/1glJRJ6znXsYJwF2AAI0w6xhN59ebcEMO8Qr0JU2mLnU/edit#gid=1814435867. This PR doesn't include any Housing Basics page updates since those are handled in PRs #1405 and #1411.
How Can This Be Tested/Reviewed?
This can be tested by verifying that each string on the google sheet is reflected in the previews. These strings are primarily found on the homepage and get assistance page.
Checklist:
yarn generate:client
and/or created a migration if I made backend changes that require themReviewer Notes:
Steps to review a PR:
On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.