Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1389/content + translation updates #1409

Merged
merged 8 commits into from
Aug 9, 2022
Merged

Conversation

ColinBuyck
Copy link
Collaborator

@ColinBuyck ColinBuyck commented Jul 28, 2022

Pull Request Template

Issue Overview

This PR addresses #1389

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

This PR includes both content updates and translations based on the Ad Hoc Translations tab of https://docs.google.com/spreadsheets/d/1glJRJ6znXsYJwF2AAI0w6xhN59ebcEMO8Qr0JU2mLnU/edit#gid=1814435867. This PR doesn't include any Housing Basics page updates since those are handled in PRs #1405 and #1411.

How Can This Be Tested/Reviewed?

This can be tested by verifying that each string on the google sheet is reflected in the previews. These strings are primarily found on the homepage and get assistance page.

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • I have exported any new pieces added to ui-components
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

@netlify
Copy link

netlify bot commented Jul 28, 2022

Deploy Preview for detroit-public-dev ready!

Name Link
🔨 Latest commit 9ab1e87
🔍 Latest deploy log https://app.netlify.com/sites/detroit-public-dev/deploys/62f29d9554c18a00083ba160
😎 Deploy Preview https://deploy-preview-1409--detroit-public-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jul 28, 2022

Deploy Preview for detroit-partners-dev ready!

Name Link
🔨 Latest commit 9ab1e87
🔍 Latest deploy log https://app.netlify.com/sites/detroit-partners-dev/deploys/62f29d957968b80008372c9f
😎 Deploy Preview https://deploy-preview-1409--detroit-partners-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jul 28, 2022

Deploy Preview for detroit-storybook-dev ready!

Name Link
🔨 Latest commit 9ab1e87
🔍 Latest deploy log https://app.netlify.com/sites/detroit-storybook-dev/deploys/62f29d95ef343100070a60fb
😎 Deploy Preview https://deploy-preview-1409--detroit-storybook-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ColinBuyck ColinBuyck added the wip label Jul 29, 2022
@ColinBuyck ColinBuyck changed the title 1389/translation updates 1389/content + translation updates Jul 30, 2022
@ColinBuyck
Copy link
Collaborator Author

One translation concern that came out of this was that Markdown files when presented right to left are showing the linked phone numbers from right to left as well which I don't believe is correct based on this. Has this issue come up before?

Screen Shot 2022-08-01 at 11 34 48 AM

Copy link
Collaborator

@emilyjablonski emilyjablonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ColinBuyck I don't think we've chatted about that issue before, I would love to make a separate ticket for that since it may touch things outside of translations, could you spin that up?

@ColinBuyck
Copy link
Collaborator Author

@emilyjablonski Yep!

@ColinBuyck ColinBuyck merged commit 7b9c2f4 into dev Aug 9, 2022
@ColinBuyck ColinBuyck deleted the 1389/translation-updates branch August 9, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants